feat(confirmations): show Money account in perps deposit pay picker - #45440
feat(confirmations): show Money account in perps deposit pay picker#45440jpuri wants to merge 7 commits into
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (23 files, +1781 -54)
|
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Builds ready [5af3d62]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 12 warn · 🔴 1 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
5af3d62 to
d23e54d
Compare
Builds ready [ca0c674]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ca0c674 to
5be52d4
Compare
5be52d4 to
72c333f
Compare
8a758b1 to
6418506
Compare
6418506 to
45f3445
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 45f3445. Configure here.
e80dacd to
a10366e
Compare
Gate a sectioned Pay with sheet on enableMoneyAccountTransactions so users can fund perps deposits from Money account when the flag is on, with matching icon sizing in the payment method rows.
a10366e to
ee9d5ee
Compare
Builds ready [ce9e4b0]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 12 warn · 🔴 1 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Satisfy Hex address/chainId checks in pay-with section tests so tsc passes.
Builds ready [425434f] [reused from ce9e4b0]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 12 warn · 🔴 1 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Keep en_GB identical to en after adding Money account pay picker strings.
Keep enableMoneyAccountTransactions off in production-default fixtures so Perps E2E stays on the legacy pay path.
|
Builds ready [9381f1f]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 13 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|




Description
UI-only confirmations Pay with changes for perps deposit:
Address derivation and live balance fetching are intentionally omitted for now.
Changelog
CHANGELOG entry: Added the option to fund Perps deposits from Money account
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1736
Manual testing steps
confirmations_pay_extended.enableMoneyAccountTransactions.perpsDeposit.Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches transaction payment selection and pay-controller config, but the feature is remote-flagged off by default and still uses placeholder Money account balance data.
Overview
Adds a flag-gated Money account option to the Perps deposit Pay with picker, with minimal controller wiring so the selection can be stored as a payment override.
When
confirmations_pay_extended.enableMoneyAccountTransactionsis enabled for the transaction type, the modal switches from the flat token list to sectioned options: Money account (dummy$7.05balance for now) above a Crypto section with the current token and an Other assets drill-in. Selecting Money account setsPaymentOverride.MoneyAccount(andrefundTofor deposits); picking a crypto token clears the override.Also updates the inline
PayWithRowto show the Money account icon/label when that override is active. Address derivation and live balance fetching are intentionally deferred.Reviewed by Cursor Bugbot for commit 9381f1f. Bugbot is set up for automated code reviews on this repo. Configure here.