Skip to content

feat(confirmations): show Money account in perps deposit pay picker - #45440

Open
jpuri wants to merge 7 commits into
mainfrom
feat/confirmations-pay-with-money-account
Open

feat(confirmations): show Money account in perps deposit pay picker#45440
jpuri wants to merge 7 commits into
mainfrom
feat/confirmations-pay-with-money-account

Conversation

@jpuri

@jpuri jpuri commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description

UI-only confirmations Pay with changes for perps deposit:

  • Sectioned Pay with sheet with a Money account row (flag-gated)
  • Mobile-matched icon sizing in payment method rows (predefined TokenIcon sizes)
  • Temporary dummy Money account balance for display
  • Minimal pay-controller wiring so the selected Money account override can be stored from the UI

Address derivation and live balance fetching are intentionally omitted for now.

Changelog

CHANGELOG entry: Added the option to fund Perps deposits from Money account

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1736

Manual testing steps

  1. Enable confirmations_pay_extended.enableMoneyAccountTransactions.perpsDeposit.
  2. Open Perps and start a deposit.
  3. On confirmation, open Pay with.
  4. Verify Money account appears above CRYPTO with the dummy available balance.
  5. Select Money account, then switch back to a crypto token / Other assets.
  6. Confirm icon sizing matches mobile (icons sit inside the larger circular slots).

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches transaction payment selection and pay-controller config, but the feature is remote-flagged off by default and still uses placeholder Money account balance data.

Overview
Adds a flag-gated Money account option to the Perps deposit Pay with picker, with minimal controller wiring so the selection can be stored as a payment override.

When confirmations_pay_extended.enableMoneyAccountTransactions is enabled for the transaction type, the modal switches from the flat token list to sectioned options: Money account (dummy $7.05 balance for now) above a Crypto section with the current token and an Other assets drill-in. Selecting Money account sets PaymentOverride.MoneyAccount (and refundTo for deposits); picking a crypto token clears the override.

Also updates the inline PayWithRow to show the Money account icon/label when that override is active. Address derivation and live balance fetching are intentionally deferred.

Reviewed by Cursor Bugbot for commit 9381f1f. Bugbot is set up for automated code reviews on this repo. Configure here.

@jpuri
jpuri deployed to pr-comment August 12, 2026 07:29 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (23 files, +1781 -54)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 modals/
            • 📁 pay-with-modal/
              • 📄 pay-with-modal.test.tsx +110 -0
              • 📄 pay-with-modal.tsx +53 -10
              • 📄 pay-with-modal.types.ts +21 -0
              • 📄 pay-with-section.test.tsx +68 -0
              • 📄 pay-with-section.tsx +39 -0
              • 📄 payment-method-row.test.tsx +97 -0
              • 📄 payment-method-row.tsx +135 -0
          • 📁 rows/
            • 📁 pay-with-row/
              • 📄 pay-with-row.test.tsx +55 -22
              • 📄 pay-with-row.tsx +20 -6
        • 📁 hooks/
          • 📁 pay/
            • 📁 sections/
              • 📄 usePayWithCryptoSection.test.tsx +187 -0
              • 📄 usePayWithCryptoSection.tsx +133 -0
              • 📄 usePayWithMoneyAccountSection.test.tsx +124 -0
              • 📄 usePayWithMoneyAccountSection.tsx +83 -0
              • 📄 useClearPaymentOverride.test.ts +69 -0
              • 📄 useClearPaymentOverride.ts +27 -0
              • 📄 usePayWithSections.test.ts +67 -0
              • 📄 usePayWithSections.ts +33 -0
              • 📄 usePayWithToken.test.tsx +216 -0
              • 📄 usePayWithToken.tsx +38 -13
        • 📁 selectors/
          • 📄 feature-flags.test.ts +63 -0
          • 📄 feature-flags.ts +40 -0
        • 📁 utils/
          • 📄 transaction-pay-money-account.test.ts +58 -0
          • 📄 transaction-pay.ts +45 -3

@metamask-ci metamask-ci Bot added the team-confirmations Push issues to confirmations team label Aug 12, 2026
@socket-security

socket-security Bot commented Aug 12, 2026

Copy link
Copy Markdown

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@jpuri
jpuri deployed to pr-comment August 12, 2026 07:58 — with GitHub Actions Active
@metamask-ci

metamask-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [5af3d62]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 12 warn · 🔴 1 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 31574196397 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]
🟡 load_new_account
🟡 [CI log]
🟡 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +18%
  • loadNewAccount/total: +18%
  • loadNewAccount/inp: +21%
  • confirmTx/longTaskTotalDuration: -16%
  • confirmTx/longTaskMaxDuration: +32%
  • confirmTx/tbt: -29%
  • bridgeUserActions/bridge_load_asset_picker: +34%
  • bridgeUserActions/longTaskCount: +11%
  • bridgeUserActions/longTaskTotalDuration: -19%
  • bridgeUserActions/longTaskMaxDuration: -26%
  • bridgeUserActions/tbt: -61%
  • bridgeUserActions/inp: +31%
  • loadNewAccount/load_new_account: +24%
  • loadNewAccount/total: +24%
  • loadNewAccount/inp: -24%
  • loadNewAccount/lcp: +1172%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -24%
  • confirmTx/lcp: +1197%
  • bridgeUserActions/bridge_load_page: +182%
  • bridgeUserActions/bridge_load_asset_picker: +87%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +30%
  • bridgeUserActions/inp: -23%
  • bridgeUserActions/lcp: +1108%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/setupStore: -17%
  • startupStandardHome/numNetworkReqs: -17%
  • startupStandardHome/longTaskCount: -33%
  • startupStandardHome/longTaskTotalDuration: -15%
  • startupStandardHome/tbt: -12%
  • startupStandardHome/lcp: +314%
  • startupStandardHome/domInteractive: +34%
  • startupStandardHome/backgroundConnect: +11%
  • startupStandardHome/firstReactRender: -98%
  • startupStandardHome/numNetworkReqs: -13%
  • startupStandardHome/fcp: +39%
  • startupStandardHome/lcp: +11%
  • startupPowerUserHome/load: +16%
  • startupPowerUserHome/domContentLoaded: +16%
  • startupPowerUserHome/domInteractive: +18%
  • startupPowerUserHome/backgroundConnect: +35%
  • startupPowerUserHome/firstReactRender: -99%
  • startupPowerUserHome/initialActions: +11%
  • startupPowerUserHome/loadScripts: +15%
  • startupPowerUserHome/setupStore: +272%
  • startupPowerUserHome/numNetworkReqs: +10%
  • startupPowerUserHome/fcp: +18%
  • startupPowerUserHome/lcp: +16%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 3.3s
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]
🔴 total
🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
🟡 assetClickToPriceChart
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/confirmSrpToPwForm: -15%
  • onboardingImportWallet/pwFormToMetricsScreen: -18%
  • onboardingImportWallet/metricsToWalletReadyScreen: -43%
  • onboardingImportWallet/doneButtonToHomeScreen: -92%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -62%
  • onboardingImportWallet/longTaskCount: -86%
  • onboardingImportWallet/longTaskTotalDuration: -96%
  • onboardingImportWallet/longTaskMaxDuration: -93%
  • onboardingImportWallet/tbt: -100%
  • onboardingImportWallet/total: -84%
  • onboardingNewWallet/skipBackupToMetricsScreen: -15%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: -10%
  • onboardingNewWallet/longTaskCount: -38%
  • onboardingNewWallet/longTaskTotalDuration: -54%
  • onboardingNewWallet/longTaskMaxDuration: -40%
  • onboardingNewWallet/tbt: -85%
  • solanaAssetDetails/assetClickToPriceChart: +256%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: +256%
  • solanaAssetDetails/inp: +11%
  • solanaAssetDetails/fcp: +18%
  • importSrpHome/homeAfterImportWithNewWallet: -13%
  • importSrpHome/longTaskCount: -30%
  • importSrpHome/longTaskTotalDuration: -38%
  • importSrpHome/longTaskMaxDuration: -23%
  • importSrpHome/tbt: -41%
  • importSrpHome/total: -12%
  • importSrpHome/inp: -35%
  • importSrpHome/cls: +484%
  • sendTransactions/openSendPageFromHome: +75%
  • sendTransactions/selectTokenToSendFormLoaded: +78%
  • sendTransactions/reviewTransactionToConfirmationPage: -97%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -93%
  • sendTransactions/inp: -19%
  • sendTransactions/fcp: +14%
  • sendTransactions/lcp: -58%
  • sendTransactions/cls: +171%
  • swap/openSwapPageFromHome: +832%
  • swap/fetchAndDisplaySwapQuotes: +119%
  • swap/longTaskCount: +33%
  • swap/tbt: -47%
  • swap/total: +133%
  • swap/lcp: -71%
  • swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 importSrpHome/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🟡 swap/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 2.0s
  • 🔴 sendTransactions/INP: p75 736ms
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🟡 swap/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • dappPageLoad/pageLoadTime: -58%
  • dappPageLoad/firstPaint: -41%
  • dappPageLoad/firstContentfulPaint: -41%
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 139.32 KiB (0.96%)
  • ui: 10.58 KiB (0.06%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 6.06 KiB (0.32%)
  • zip: 43.23 KiB (0.2%)

@jpuri
jpuri force-pushed the feat/confirmations-pay-with-money-account branch from 5af3d62 to d23e54d Compare August 12, 2026 08:08
@jpuri
jpuri deployed to pr-comment August 12, 2026 08:08 — with GitHub Actions Active
@jpuri jpuri added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Aug 12, 2026
@jpuri
jpuri deployed to pr-comment August 12, 2026 08:17 — with GitHub Actions Active
@jpuri
jpuri deployed to pr-comment August 12, 2026 08:40 — with GitHub Actions Active
@metamask-ci

metamask-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [ca0c674]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 12 warn · 🔴 0 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 31577656290 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]
🟡 load_new_account
🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +18%
  • loadNewAccount/total: +18%
  • loadNewAccount/inp: +14%
  • confirmTx/longTaskTotalDuration: -16%
  • confirmTx/longTaskMaxDuration: +35%
  • confirmTx/tbt: -29%
  • bridgeUserActions/bridge_load_asset_picker: +110%
  • bridgeUserActions/longTaskCount: +11%
  • bridgeUserActions/tbt: -27%
  • bridgeUserActions/total: +15%
  • loadNewAccount/inp: -32%
  • loadNewAccount/fcp: -66%
  • loadNewAccount/lcp: +942%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -47%
  • confirmTx/fcp: -57%
  • confirmTx/lcp: +1235%
  • bridgeUserActions/bridge_load_page: +154%
  • bridgeUserActions/bridge_load_asset_picker: +79%
  • bridgeUserActions/bridge_search_token: -10%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +24%
  • bridgeUserActions/inp: -38%
  • bridgeUserActions/fcp: -72%
  • bridgeUserActions/lcp: +914%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts
startupPowerUserHome
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/uiStartup: -35%
  • startupStandardHome/load: -33%
  • startupStandardHome/domContentLoaded: -33%
  • startupStandardHome/domInteractive: -29%
  • startupStandardHome/firstPaint: -17%
  • startupStandardHome/backgroundConnect: -31%
  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/initialActions: -33%
  • startupStandardHome/loadScripts: -33%
  • startupStandardHome/setupStore: -39%
  • startupStandardHome/numNetworkReqs: -17%
  • startupStandardHome/longTaskCount: -33%
  • startupStandardHome/longTaskTotalDuration: -42%
  • startupStandardHome/longTaskMaxDuration: -38%
  • startupStandardHome/tbt: -45%
  • startupStandardHome/inp: -18%
  • startupStandardHome/fcp: -33%
  • startupStandardHome/lcp: +194%
  • startupStandardHome/load: +11%
  • startupStandardHome/domContentLoaded: +11%
  • startupStandardHome/domInteractive: -11%
  • startupStandardHome/backgroundConnect: +16%
  • startupStandardHome/firstReactRender: -98%
  • startupStandardHome/numNetworkReqs: -13%
  • startupStandardHome/lcp: +14%
  • startupPowerUserHome/uiStartup: -30%
  • startupPowerUserHome/load: -18%
  • startupPowerUserHome/domContentLoaded: -18%
  • startupPowerUserHome/backgroundConnect: -28%
  • startupPowerUserHome/firstReactRender: -99%
  • startupPowerUserHome/initialActions: -44%
  • startupPowerUserHome/loadScripts: -19%
  • startupPowerUserHome/setupStore: +113%
  • startupPowerUserHome/numNetworkReqs: +29%
  • startupPowerUserHome/inp: -32%
  • startupPowerUserHome/lcp: -22%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
sendTransactions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: +19%
  • onboardingImportWallet/confirmSrpToPwForm: +11%
  • onboardingImportWallet/metricsToWalletReadyScreen: -14%
  • onboardingImportWallet/doneButtonToHomeScreen: -80%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -57%
  • onboardingImportWallet/longTaskCount: -86%
  • onboardingImportWallet/longTaskTotalDuration: -96%
  • onboardingImportWallet/longTaskMaxDuration: -92%
  • onboardingImportWallet/tbt: -99%
  • onboardingImportWallet/total: -82%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +75%
  • onboardingNewWallet/doneButtonToAssetList: -75%
  • onboardingNewWallet/longTaskCount: -69%
  • onboardingNewWallet/longTaskTotalDuration: -75%
  • onboardingNewWallet/longTaskMaxDuration: -42%
  • onboardingNewWallet/tbt: -88%
  • onboardingNewWallet/total: -72%
  • solanaAssetDetails/assetClickToPriceChart: +266%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: +266%
  • solanaAssetDetails/inp: +11%
  • solanaAssetDetails/fcp: +16%
  • solanaAssetDetails/lcp: +16%
  • importSrpHome/loginToHomeScreen: -18%
  • importSrpHome/homeAfterImportWithNewWallet: -59%
  • importSrpHome/longTaskCount: -51%
  • importSrpHome/longTaskTotalDuration: -52%
  • importSrpHome/longTaskMaxDuration: -39%
  • importSrpHome/tbt: -53%
  • importSrpHome/total: -55%
  • importSrpHome/inp: -51%
  • importSrpHome/cls: +484%
  • sendTransactions/selectTokenToSendFormLoaded: -10%
  • sendTransactions/reviewTransactionToConfirmationPage: -97%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -94%
  • sendTransactions/inp: -26%
  • sendTransactions/fcp: +16%
  • sendTransactions/lcp: -60%
  • sendTransactions/cls: +171%
  • swap/openSwapPageFromHome: +808%
  • swap/fetchAndDisplaySwapQuotes: +110%
  • swap/longTaskCount: +167%
  • swap/longTaskTotalDuration: +79%
  • swap/tbt: -21%
  • swap/total: +121%
  • swap/lcp: -70%
  • swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🟡 swap/FCP: p75 1.8s
  • 🟡 solanaAssetDetails/FCP: p75 2.1s
  • 🔴 sendTransactions/INP: p75 776ms
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🟡 swap/FCP: p75 2.0s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • dappPageLoad/pageLoadTime: -57%
  • dappPageLoad/firstPaint: -41%
  • dappPageLoad/firstContentfulPaint: -41%
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 874 Bytes (0.01%)
  • ui: 13.39 KiB (0.07%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 84 Bytes (0%)
  • zip: 5.97 KiB (0.03%)

@jpuri
jpuri force-pushed the feat/confirmations-pay-with-money-account branch from ca0c674 to 5be52d4 Compare August 12, 2026 09:34
@jpuri
jpuri deployed to pr-comment August 12, 2026 09:34 — with GitHub Actions Active
@jpuri
jpuri force-pushed the feat/confirmations-pay-with-money-account branch from 5be52d4 to 72c333f Compare August 12, 2026 09:35
@jpuri
jpuri deployed to pr-comment August 12, 2026 09:35 — with GitHub Actions Active
@jpuri
jpuri deployed to pr-comment August 12, 2026 09:42 — with GitHub Actions Active
@jpuri
jpuri force-pushed the feat/confirmations-pay-with-money-account branch from 8a758b1 to 6418506 Compare August 12, 2026 09:43
@jpuri
jpuri deployed to pr-comment August 12, 2026 09:43 — with GitHub Actions Active
@jpuri
jpuri marked this pull request as ready for review August 12, 2026 09:44
@jpuri
jpuri requested a review from a team as a code owner August 12, 2026 09:44
@jpuri
jpuri deployed to pr-comment August 12, 2026 09:44 — with GitHub Actions Active
@jpuri
jpuri enabled auto-merge August 12, 2026 09:44
@jpuri
jpuri force-pushed the feat/confirmations-pay-with-money-account branch from 6418506 to 45f3445 Compare August 12, 2026 09:45
@jpuri
jpuri deployed to pr-comment August 12, 2026 09:46 — with GitHub Actions Active

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 45f3445. Configure here.

Comment thread ui/pages/confirmations/hooks/pay/sections/usePayWithCryptoSection.tsx Outdated
@jpuri
jpuri force-pushed the feat/confirmations-pay-with-money-account branch from e80dacd to a10366e Compare August 12, 2026 10:27
@jpuri
jpuri deployed to pr-comment August 12, 2026 10:27 — with GitHub Actions Active
Gate a sectioned Pay with sheet on enableMoneyAccountTransactions so users
can fund perps deposits from Money account when the flag is on, with
matching icon sizing in the payment method rows.
@jpuri
jpuri force-pushed the feat/confirmations-pay-with-money-account branch from a10366e to ee9d5ee Compare August 12, 2026 10:32
@jpuri
jpuri deployed to pr-comment August 12, 2026 10:32 — with GitHub Actions Active
@jpuri
jpuri deployed to pr-comment August 12, 2026 10:45 — with GitHub Actions Active
@jpuri
jpuri deployed to pr-comment August 12, 2026 10:49 — with GitHub Actions Active
@matthewwalsh0
matthewwalsh0 requested a review from OGPoyraz August 12, 2026 10:53
@jpuri
jpuri deployed to pr-comment August 12, 2026 11:12 — with GitHub Actions Active
@metamask-ci

metamask-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [ce9e4b0]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 12 warn · 🔴 1 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 31589139704 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]
🟡 load_new_account
🟡 [CI log]
🟡 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +18%
  • loadNewAccount/total: +18%
  • loadNewAccount/inp: +29%
  • loadNewAccount/fcp: +24%
  • loadNewAccount/lcp: +17%
  • confirmTx/longTaskTotalDuration: -16%
  • confirmTx/longTaskMaxDuration: +36%
  • confirmTx/tbt: -29%
  • bridgeUserActions/bridge_load_asset_picker: +201%
  • bridgeUserActions/longTaskCount: -44%
  • bridgeUserActions/longTaskTotalDuration: -50%
  • bridgeUserActions/longTaskMaxDuration: -23%
  • bridgeUserActions/tbt: -61%
  • bridgeUserActions/total: +25%
  • loadNewAccount/load_new_account: +21%
  • loadNewAccount/total: +21%
  • loadNewAccount/inp: +36%
  • loadNewAccount/fcp: -73%
  • loadNewAccount/lcp: +1194%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -32%
  • confirmTx/fcp: -65%
  • confirmTx/lcp: +1213%
  • bridgeUserActions/bridge_load_page: +162%
  • bridgeUserActions/bridge_load_asset_picker: +37%
  • bridgeUserActions/bridge_search_token: -12%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +15%
  • bridgeUserActions/inp: -31%
  • bridgeUserActions/fcp: -15%
  • bridgeUserActions/lcp: +951%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/numNetworkReqs: -14%
  • startupStandardHome/uiStartup: -24%
  • startupStandardHome/load: -20%
  • startupStandardHome/domContentLoaded: -20%
  • startupStandardHome/domInteractive: -44%
  • startupStandardHome/backgroundConnect: -15%
  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/initialActions: -50%
  • startupStandardHome/loadScripts: -20%
  • startupStandardHome/setupStore: -25%
  • startupStandardHome/numNetworkReqs: -13%
  • startupStandardHome/fcp: -34%
  • startupStandardHome/lcp: -18%
  • startupPowerUserHome/uiStartup: -31%
  • startupPowerUserHome/load: -20%
  • startupPowerUserHome/domContentLoaded: -20%
  • startupPowerUserHome/domInteractive: +15%
  • startupPowerUserHome/backgroundConnect: -32%
  • startupPowerUserHome/firstReactRender: -99%
  • startupPowerUserHome/initialActions: -44%
  • startupPowerUserHome/loadScripts: -20%
  • startupPowerUserHome/setupStore: -78%
  • startupPowerUserHome/numNetworkReqs: +17%
  • startupPowerUserHome/inp: -32%
  • startupPowerUserHome/lcp: -22%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
🟡 assetClickToPriceChart
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: +13%
  • onboardingImportWallet/pwFormToMetricsScreen: +30%
  • onboardingImportWallet/doneButtonToHomeScreen: -78%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -54%
  • onboardingImportWallet/longTaskCount: -86%
  • onboardingImportWallet/longTaskTotalDuration: -95%
  • onboardingImportWallet/longTaskMaxDuration: -91%
  • onboardingImportWallet/tbt: -99%
  • onboardingImportWallet/total: -81%
  • onboardingNewWallet/srpButtonToPwForm: -11%
  • onboardingNewWallet/createPwToRecoveryScreen: -22%
  • onboardingNewWallet/skipBackupToMetricsScreen: -31%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: -28%
  • onboardingNewWallet/doneButtonToAssetList: -81%
  • onboardingNewWallet/longTaskCount: -69%
  • onboardingNewWallet/longTaskTotalDuration: -77%
  • onboardingNewWallet/longTaskMaxDuration: -45%
  • onboardingNewWallet/tbt: -91%
  • onboardingNewWallet/total: -78%
  • solanaAssetDetails/assetClickToPriceChart: +267%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: +267%
  • solanaAssetDetails/fcp: +19%
  • importSrpHome/homeAfterImportWithNewWallet: -25%
  • importSrpHome/longTaskCount: -44%
  • importSrpHome/longTaskTotalDuration: -43%
  • importSrpHome/longTaskMaxDuration: -29%
  • importSrpHome/tbt: -43%
  • importSrpHome/total: -23%
  • importSrpHome/inp: -51%
  • importSrpHome/lcp: -10%
  • importSrpHome/cls: +497%
  • sendTransactions/openSendPageFromHome: -25%
  • sendTransactions/reviewTransactionToConfirmationPage: -98%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -95%
  • sendTransactions/inp: -22%
  • sendTransactions/fcp: +12%
  • sendTransactions/lcp: -62%
  • sendTransactions/cls: +171%
  • swap/openSwapPageFromHome: +824%
  • swap/fetchAndDisplaySwapQuotes: +106%
  • swap/longTaskCount: +33%
  • swap/longTaskTotalDuration: +16%
  • swap/longTaskMaxDuration: +22%
  • swap/total: +115%
  • swap/lcp: -71%
  • swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 1.8s
  • 🟡 swap/FCP: p75 1.8s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 2.0s
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🟡 swap/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • dappPageLoad/pageLoadTime: -58%
  • dappPageLoad/firstPaint: -46%
  • dappPageLoad/firstContentfulPaint: -46%
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 874 Bytes (0.01%)
  • ui: 13.37 KiB (0.07%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 84 Bytes (0%)
  • zip: 5.97 KiB (0.03%)

OGPoyraz
OGPoyraz previously approved these changes Aug 12, 2026
Satisfy Hex address/chainId checks in pay-with section tests so tsc passes.
@metamask-ci

metamask-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [425434f] [reused from ce9e4b0]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 12 warn · 🔴 1 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 31591730248 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]
🟡 load_new_account
🟡 [CI log]
🟡 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +18%
  • loadNewAccount/total: +18%
  • loadNewAccount/inp: +29%
  • loadNewAccount/fcp: +24%
  • loadNewAccount/lcp: +17%
  • confirmTx/longTaskTotalDuration: -16%
  • confirmTx/longTaskMaxDuration: +36%
  • confirmTx/tbt: -29%
  • bridgeUserActions/bridge_load_asset_picker: +201%
  • bridgeUserActions/longTaskCount: -44%
  • bridgeUserActions/longTaskTotalDuration: -50%
  • bridgeUserActions/longTaskMaxDuration: -23%
  • bridgeUserActions/tbt: -61%
  • bridgeUserActions/total: +25%
  • loadNewAccount/load_new_account: +21%
  • loadNewAccount/total: +21%
  • loadNewAccount/inp: +36%
  • loadNewAccount/fcp: -73%
  • loadNewAccount/lcp: +1194%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -32%
  • confirmTx/fcp: -65%
  • confirmTx/lcp: +1213%
  • bridgeUserActions/bridge_load_page: +162%
  • bridgeUserActions/bridge_load_asset_picker: +37%
  • bridgeUserActions/bridge_search_token: -12%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +15%
  • bridgeUserActions/inp: -31%
  • bridgeUserActions/fcp: -15%
  • bridgeUserActions/lcp: +951%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/numNetworkReqs: -14%
  • startupStandardHome/uiStartup: -24%
  • startupStandardHome/load: -20%
  • startupStandardHome/domContentLoaded: -20%
  • startupStandardHome/domInteractive: -44%
  • startupStandardHome/backgroundConnect: -15%
  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/initialActions: -50%
  • startupStandardHome/loadScripts: -20%
  • startupStandardHome/setupStore: -25%
  • startupStandardHome/numNetworkReqs: -13%
  • startupStandardHome/fcp: -34%
  • startupStandardHome/lcp: -18%
  • startupPowerUserHome/uiStartup: -31%
  • startupPowerUserHome/load: -20%
  • startupPowerUserHome/domContentLoaded: -20%
  • startupPowerUserHome/domInteractive: +15%
  • startupPowerUserHome/backgroundConnect: -32%
  • startupPowerUserHome/firstReactRender: -99%
  • startupPowerUserHome/initialActions: -44%
  • startupPowerUserHome/loadScripts: -20%
  • startupPowerUserHome/setupStore: -78%
  • startupPowerUserHome/numNetworkReqs: +17%
  • startupPowerUserHome/inp: -32%
  • startupPowerUserHome/lcp: -22%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
🟡 assetClickToPriceChart
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: +13%
  • onboardingImportWallet/pwFormToMetricsScreen: +30%
  • onboardingImportWallet/doneButtonToHomeScreen: -78%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -54%
  • onboardingImportWallet/longTaskCount: -86%
  • onboardingImportWallet/longTaskTotalDuration: -95%
  • onboardingImportWallet/longTaskMaxDuration: -91%
  • onboardingImportWallet/tbt: -99%
  • onboardingImportWallet/total: -81%
  • onboardingNewWallet/srpButtonToPwForm: -11%
  • onboardingNewWallet/createPwToRecoveryScreen: -22%
  • onboardingNewWallet/skipBackupToMetricsScreen: -31%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: -28%
  • onboardingNewWallet/doneButtonToAssetList: -81%
  • onboardingNewWallet/longTaskCount: -69%
  • onboardingNewWallet/longTaskTotalDuration: -77%
  • onboardingNewWallet/longTaskMaxDuration: -45%
  • onboardingNewWallet/tbt: -91%
  • onboardingNewWallet/total: -78%
  • solanaAssetDetails/assetClickToPriceChart: +267%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: +267%
  • solanaAssetDetails/fcp: +19%
  • importSrpHome/homeAfterImportWithNewWallet: -25%
  • importSrpHome/longTaskCount: -44%
  • importSrpHome/longTaskTotalDuration: -43%
  • importSrpHome/longTaskMaxDuration: -29%
  • importSrpHome/tbt: -43%
  • importSrpHome/total: -23%
  • importSrpHome/inp: -51%
  • importSrpHome/lcp: -10%
  • importSrpHome/cls: +497%
  • sendTransactions/openSendPageFromHome: -25%
  • sendTransactions/reviewTransactionToConfirmationPage: -98%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -95%
  • sendTransactions/inp: -22%
  • sendTransactions/fcp: +12%
  • sendTransactions/lcp: -62%
  • sendTransactions/cls: +171%
  • swap/openSwapPageFromHome: +824%
  • swap/fetchAndDisplaySwapQuotes: +106%
  • swap/longTaskCount: +33%
  • swap/longTaskTotalDuration: +16%
  • swap/longTaskMaxDuration: +22%
  • swap/total: +115%
  • swap/lcp: -71%
  • swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 1.8s
  • 🟡 swap/FCP: p75 1.8s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 2.0s
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🟡 swap/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • dappPageLoad/pageLoadTime: -58%
  • dappPageLoad/firstPaint: -46%
  • dappPageLoad/firstContentfulPaint: -46%
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 874 Bytes (0.01%)
  • ui: 13.37 KiB (0.07%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 84 Bytes (0%)
  • zip: 5.97 KiB (0.03%)

Keep en_GB identical to en after adding Money account pay picker strings.
@jpuri
jpuri deployed to pr-comment August 12, 2026 11:50 — with GitHub Actions Active
Keep enableMoneyAccountTransactions off in production-default fixtures so Perps E2E stays on the legacy pay path.
@jpuri
jpuri deployed to pr-comment August 12, 2026 11:52 — with GitHub Actions Active
@sonarqubecloud

Copy link
Copy Markdown

@jpuri
jpuri deployed to pr-comment August 12, 2026 12:18 — with GitHub Actions Active
@metamask-ci

metamask-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [9381f1f]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 13 warn · 🔴 0 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 31593793831 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]
🟡 load_new_account
🟡 [CI log]
🟡 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +19%
  • loadNewAccount/total: +19%
  • loadNewAccount/inp: +14%
  • loadNewAccount/fcp: +16%
  • confirmTx/longTaskMaxDuration: +57%
  • confirmTx/inp: +14%
  • confirmTx/fcp: +16%
  • confirmTx/lcp: +17%
  • bridgeUserActions/bridge_load_page: +35%
  • bridgeUserActions/bridge_load_asset_picker: +123%
  • bridgeUserActions/longTaskCount: +67%
  • bridgeUserActions/longTaskTotalDuration: +44%
  • bridgeUserActions/total: +17%
  • bridgeUserActions/inp: +31%
  • bridgeUserActions/fcp: +14%
  • bridgeUserActions/lcp: +29%
  • loadNewAccount/load_new_account: +23%
  • loadNewAccount/total: +23%
  • loadNewAccount/inp: -17%
  • loadNewAccount/fcp: +11%
  • loadNewAccount/lcp: +1437%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/lcp: +1111%
  • bridgeUserActions/bridge_load_page: +247%
  • bridgeUserActions/bridge_load_asset_picker: +169%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +40%
  • bridgeUserActions/lcp: +1218%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 loadNewAccount/LCP: p75 2.7s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/firstPaint: +15%
  • startupStandardHome/backgroundConnect: +11%
  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/numNetworkReqs: -14%
  • startupStandardHome/inp: +14%
  • startupStandardHome/domInteractive: -32%
  • startupStandardHome/firstReactRender: -98%
  • startupStandardHome/numNetworkReqs: -13%
  • startupStandardHome/fcp: -29%
  • startupPowerUserHome/load: +14%
  • startupPowerUserHome/domContentLoaded: +14%
  • startupPowerUserHome/domInteractive: +24%
  • startupPowerUserHome/backgroundConnect: +32%
  • startupPowerUserHome/firstReactRender: -99%
  • startupPowerUserHome/initialActions: +11%
  • startupPowerUserHome/loadScripts: +13%
  • startupPowerUserHome/setupStore: +288%
  • startupPowerUserHome/fcp: +24%
  • startupPowerUserHome/lcp: +22%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 3.5s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: +18%
  • onboardingImportWallet/confirmSrpToPwForm: +11%
  • onboardingImportWallet/pwFormToMetricsScreen: +11%
  • onboardingImportWallet/doneButtonToHomeScreen: -78%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -92%
  • onboardingImportWallet/longTaskCount: -86%
  • onboardingImportWallet/longTaskTotalDuration: -94%
  • onboardingImportWallet/longTaskMaxDuration: -92%
  • onboardingImportWallet/tbt: -99%
  • onboardingImportWallet/total: -81%
  • onboardingNewWallet/createPwToRecoveryScreen: -14%
  • onboardingNewWallet/skipBackupToMetricsScreen: -20%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: -23%
  • onboardingNewWallet/doneButtonToAssetList: -82%
  • onboardingNewWallet/longTaskCount: -69%
  • onboardingNewWallet/longTaskTotalDuration: -79%
  • onboardingNewWallet/longTaskMaxDuration: -50%
  • onboardingNewWallet/tbt: -100%
  • onboardingNewWallet/total: -79%
  • solanaAssetDetails/assetClickToPriceChart: +278%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: +278%
  • solanaAssetDetails/fcp: +20%
  • solanaAssetDetails/lcp: +10%
  • importSrpHome/homeAfterImportWithNewWallet: -20%
  • importSrpHome/longTaskCount: -30%
  • importSrpHome/longTaskTotalDuration: -34%
  • importSrpHome/longTaskMaxDuration: -21%
  • importSrpHome/tbt: -37%
  • importSrpHome/total: -18%
  • importSrpHome/inp: -46%
  • importSrpHome/cls: +494%
  • sendTransactions/selectTokenToSendFormLoaded: +25%
  • sendTransactions/reviewTransactionToConfirmationPage: -98%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -95%
  • sendTransactions/inp: -30%
  • sendTransactions/lcp: -61%
  • sendTransactions/cls: +171%
  • swap/openSwapPageFromHome: +804%
  • swap/fetchAndDisplaySwapQuotes: +124%
  • swap/longTaskCount: +33%
  • swap/tbt: -63%
  • swap/total: +131%
  • swap/lcp: -71%
  • swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 1.8s
  • 🟡 swap/FCP: p75 1.8s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🔴 sendTransactions/INP: p75 552ms
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • dappPageLoad/pageLoadTime: -58%
  • dappPageLoad/firstPaint: -46%
  • dappPageLoad/firstContentfulPaint: -46%
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 874 Bytes (0.01%)
  • ui: 13.37 KiB (0.07%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 84 Bytes (0%)
  • zip: 6.09 KiB (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed risk:medium size-XL team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants