test(e2e): add POM anti-pattern review rules (MMQA-2248) - #45439
Draft
racitores wants to merge 6 commits into
Draft
test(e2e): add POM anti-pattern review rules (MMQA-2248)#45439racitores wants to merge 6 commits into
racitores wants to merge 6 commits into
Conversation
Expand BUGBOT/CODEBOT/AGENTS coverage for POM anti-patterns and add intentional probe files so we can verify Bugbot flags them on the PR. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (2 files, +82 -0)
|
Contributor
Builds ready [ab9f53b] [reused from 4b2c00b]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 10 warn · 🔴 4 fail)
Bundle size diffs
|
Contributor
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ab9f53b. Configure here.
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
bugbot run verbose=true |
Contributor
|
Bugbot request id: serverGenReqId_2b6be6e9-2940-463b-854a-800485c079dc |
Contributor
Bugbot rules debugBugbot rules included in this run
Bugbot request id: serverGenReqId_2b6be6e9-2940-463b-854a-800485c079dc |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1982444. Configure here.
Rewrite BUGBOT.md 3.3-3.9 as short flag/do-not-flag rules and make the sample files read like ordinary E2E code so the rules are exercised realistically. Co-authored-by: Cursor <cursoragent@cursor.com>
racitores
changed the title
Contributor
Author
|
bugbot run verbose=true |
Contributor
|
Bugbot request id: serverGenReqId_9902f0b2-dbb4-4729-95df-b869fc80adb8 |
Contributor
Bugbot rules debugBugbot rules included in this run
Bugbot request id: serverGenReqId_9902f0b2-dbb4-4729-95df-b869fc80adb8 |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e20a3ec. Configure here.
Contributor
Author
|
bugbot run verbose=true |
Contributor
|
Bugbot request id: serverGenReqId_1fbdb9e0-6435-446a-a3a2-0634d0eeed05 |
Contributor
Bugbot rules debugBugbot rules included in this run
Bugbot request id: serverGenReqId_1fbdb9e0-6435-446a-a3a2-0634d0eeed05 |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e20a3ec. Configure here.
Scope the imperative Page Object Model rules under test/e2e so Bugbot loads them when reviewing E2E changes. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
bugbot run verbose=true |
Contributor
|
Bugbot request id: serverGenReqId_6fd7571a-a46f-4d6e-aec9-43da72cde88a |
Contributor
Bugbot rules debugBugbot rules included in this run
Bugbot request id: serverGenReqId_6fd7571a-a46f-4d6e-aec9-43da72cde88a |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit bb19286. Configure here.
Add an activity tab flow, a settings helper on the page object, and a token list test. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
bugbot run verbose=true |
Contributor
|
Bugbot request id: serverGenReqId_0ae1d730-abeb-49e8-84b1-fb5d324c4c5b |
Contributor
Bugbot rules debugBugbot rules included in this run
Bugbot request id: serverGenReqId_0ae1d730-abeb-49e8-84b1-fb5d324c4c5b |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9e6459d. Configure here.
Cursor docs show Bugbot acts on rules written as an explicit regex trigger followed by an imperative "Add a [blocking|non-blocking] Bug" instruction. The previous descriptive "Flag/Do not flag" prose was loaded but never produced findings. Restate sections 3.3-3.9 and the nested E2E rules in that format, and extend the sample files with further POM violations. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
bugbot run verbose=true |
Contributor
|
Bugbot request id: serverGenReqId_b0a72bd6-a26e-4ef5-b4b4-ab6a3fbb7306 |
Contributor
Bugbot rules debugBugbot rules included in this run
Bugbot request id: serverGenReqId_b0a72bd6-a26e-4ef5-b4b4-ab6a3fbb7306 |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d4e23bb. Configure here.
Contributor
Author
|
bugbot run verbose=true |
Contributor
|
Bugbot request id: serverGenReqId_887cfa2a-472a-4288-b108-8b0136287f30 |
Contributor
Bugbot rules debugBugbot rules included in this run
Bugbot request id: serverGenReqId_887cfa2a-472a-4288-b108-8b0136287f30 |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d4e23bb. Configure here.
|
Contributor
Builds ready [d4e23bb] [reused from e20a3ec]
⚡ Performance Benchmarks (Total: 🟢 1 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Page Object Model review rules for E2E code (MMQA-2248) to
.cursor/BUGBOT.md,.cursor/commands/CODEBOT.md, andtest/e2e/AGENTS.md, plus sample E2E files used to exercise the rules end to end.Changelog
CHANGELOG entry: null
Related issues
Fixes: MMQA-2248
Manual testing steps
test/e2e/.Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes automated review rules that can block E2E PRs on POM violations, and adds sample tests that deliberately violate those patterns—confirm they are only for rule validation and will not remain as runnable suite noise.
Overview
Adds automated Page Object Model enforcement for E2E reviews (MMQA-2248). New Bugbot detectors 3.3–3.9 flag locators in flows, single-page-object flows, UI helpers and raw
drivercalls in specs, hardcoded delays, page objects calling other page objects, andtry/catchin page objects/flows—several as blocking merge defects.CODEBOTchecklists andtest/e2e/AGENTS.mdnow point at these rules, and a scopedtest/e2e/.cursor/BUGBOT.mdmirrors them for E2E-only reviews.Also adds intentionally non-compliant sample flow, page object, and spec files under
account-overviewso the new detectors can be validated end to end on this PR.Reviewed by Cursor Bugbot for commit d4e23bb. Bugbot is set up for automated code reviews on this repo. Configure here.