fix: show blind signing guidance on Ledger reconnect repair - #45433
Open
gantunesr wants to merge 3 commits into
Open
fix: show blind signing guidance on Ledger reconnect repair#45433gantunesr wants to merge 3 commits into
gantunesr wants to merge 3 commits into
Conversation
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +4 -1)
|
|
Contributor
Builds ready [83b3751]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 9 warn · 🔴 2 fail)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When reconnecting a Ledger via “Reconnect from the beginning” with blind signing disabled, the repair page showed “Device not detected…” even though the device was connected and the Ethereum app was open.
The shared
ensureDeviceReadyhelper catches hardware-wallet errors and returnsfalse, so the repair page lost the blind sign error and always mapped failure to the generic not-detected message. Blind signing failures were also mapped to a disconnect device event.This change:
ensureRepairDeviceReadyon the repair page when a wallet type is known, so device-state errors (including blind signing disabled) throw and can be surfaced.DeviceStateBlindSignNotSupportedto the localized “Enable blind signing” message.ConnectionFailedinstead ofDisconnected, so the device is not treated as unplugged.Changelog
CHANGELOG entry: Fixed Ledger reconnect repair showing “Device not detected” when blind signing was disabled instead of prompting to enable blind signing
Related issues
Fixes: #43597
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-2052
Manual testing steps
Check #43597
Screenshots/Recordings
Before
Check #43597
After
Screen.Recording.2026-08-11.at.6.04.16.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Targeted UX/error-mapping fix in the hardware-wallet repair reconnect path; no auth, signing, or transport protocol changes.
Overview
Fixes Ledger Reconnect from the beginning so a connected device with blind signing disabled no longer shows “Device not detected”.
When a wallet type is known, the repair page now prefers
ensureRepairDeviceReadyso device-state errors can throw instead of being collapsed tofalseby sharedensureDeviceReady. Blind-signing failures map to the localized enable-blind-signing message viagetRepairConnectErrorMessage.Also maps
DeviceStateBlindSignNotSupportedtoDeviceEvent.ConnectionFailed(notDisconnected), so the device is treated as a settings issue rather than unplugged.Reviewed by Cursor Bugbot for commit bf35d94. Bugbot is set up for automated code reviews on this repo. Configure here.