fix: tolerate getter-only Sentry SDK loggers - #45428
Draft
Boulea7 wants to merge 1 commit into
Draft
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents debug logger integration from throwing when the installed
@sentry/coreSDK exposes getter-only
logorerrormethods. Sentry initialization continueswhen logger redirection is unavailable. This does not change DSN, sampling,
transport, or trace-propagation behavior.
Maintainer edits: allowed.
Changelog
CHANGELOG entry: null
Related issues
Fixes: #45206
Manual testing steps
Automated verification performed:
yarn test:unit app/scripts/lib/setupSentry.test.js -t 'initializes Sentry with getter-only SDK loggers'passed (1 test passed, 48 skipped).yarn test:unit app/scripts/lib/setupSentry.test.jspassed (49/49).yarn test:unit app/scripts/libcompleted with JUnit reporting 2,130 tests and 0 failures.yarn lint:changed,yarn lint:tsc, andyarn circular-deps:checkpassed.yarn env:e2e webpack --test --sentryand, afteryarn webpack:tsc,yarn build:testpassed. Webpack emitted entrypoint-size recommendations; both builds exited successfully.No full CI run is claimed here.
Screenshots/Recordings
Not applicable: this is a non-visual background initialization compatibility fix.
Pre-merge author checklist
Pre-merge reviewer checklist