Skip to content

fix: tolerate getter-only Sentry SDK loggers - #45428

Draft
Boulea7 wants to merge 1 commit into
MetaMask:mainfrom
Boulea7:fix/45206-sentry-getter-only-logger
Draft

fix: tolerate getter-only Sentry SDK loggers#45428
Boulea7 wants to merge 1 commit into
MetaMask:mainfrom
Boulea7:fix/45206-sentry-getter-only-logger

Conversation

@Boulea7

@Boulea7 Boulea7 commented Aug 11, 2026

Copy link
Copy Markdown

Description

Prevents debug logger integration from throwing when the installed @sentry/core
SDK exposes getter-only log or error methods. Sentry initialization continues
when logger redirection is unavailable. This does not change DSN, sampling,
transport, or trace-propagation behavior.

Maintainer edits: allowed.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #45206

Manual testing steps

Automated verification performed:

  1. yarn test:unit app/scripts/lib/setupSentry.test.js -t 'initializes Sentry with getter-only SDK loggers' passed (1 test passed, 48 skipped).
  2. yarn test:unit app/scripts/lib/setupSentry.test.js passed (49/49).
  3. yarn test:unit app/scripts/lib completed with JUnit reporting 2,130 tests and 0 failures.
  4. yarn lint:changed, yarn lint:tsc, and yarn circular-deps:check passed.
  5. yarn env:e2e webpack --test --sentry and, after yarn webpack:tsc, yarn build:test passed. Webpack emitted entrypoint-size recommendations; both builds exited successfully.

No full CI run is claimed here.

Screenshots/Recordings

Not applicable: this is a non-visual background initialization compatibility fix.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Boulea7

Boulea7 commented Aug 11, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setupSentry.js's integrateLogging() crashes Sentry.init() against getter-only @sentry/core logger

1 participant