fix: show swap no-price banner when price impact is not available - #45426
Open
micaelae wants to merge 3 commits into
Open
fix: show swap no-price banner when price impact is not available#45426micaelae wants to merge 3 commits into
micaelae wants to merge 3 commits into
Conversation
Contributor
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (5 files, +140 -126)
|
Contributor
Builds ready [b7d6bc2]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 10 warn · 🔴 3 fail)
Bundle size diffs
|
Contributor
Builds ready [e9cefe3] [reused from b7d6bc2]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 10 warn · 🔴 3 fail)
Bundle size diffs
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e9cefe3. Configure here.
micaelae
changed the title
micaelae
enabled auto-merge
August 11, 2026 21:23
|
Contributor
Builds ready [de82cdb] [reused from b7d6bc2]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 10 warn · 🔴 3 fail)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After V2 quote migration, the priceData check in
getActiveQuotePriceDatawas only verifying thepriceData.priceImpactobject, which can be empty. As a result the no-price banner does not show up as expectedThis PR updates the selector to check
priceData.priceImpact.amountfor truthiness insteadChangelog
CHANGELOG entry: fix: show swap no-price banner when priceImpact is not available
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-4897
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Small selector fix restoring an existing swap/bridge warning banner; no auth, security, or data-handling changes.
Overview
Fixes the swap/bridge no-price banner not appearing after the V2 quote migration when
priceDataexists butpriceImpact.amountis missing.getActiveQuotePriceDatanow returnsundefinedunlesspriceData.priceImpact.amountis present, so theprice-data-unavailablealert triggers correctly.getFormattedPriceImpactFiatalso reads fiat impact through this selector.Tests and mocks are updated to match the new price-data shape and share
DEFAULT_VALIDATION_ERRORS.Reviewed by Cursor Bugbot for commit de82cdb. Bugbot is set up for automated code reviews on this repo. Configure here.