docs: Added jsdoc for all the page object file - #45424
Queued
hjetpoluru wants to merge 3 commits into
Queued
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/perps (6 files, +67 -10)
🧪 @MetaMask/qa (141 files, +2004 -63)
🔄 @MetaMask/swaps-engineers (1 files, +20 -0)
|
hjetpoluru
changed the title
Contributor
Builds ready [e3bd4a3] [reused from b693bdf]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 1 fail)
Bundle size diffs
|
Contributor
Builds ready [eb2b125] [reused from b693bdf]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 13 warn · 🔴 4 fail)
Bundle size diffs
|
Contributor
Builds ready [9da1c0a] [reused from b693bdf]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 13 warn · 🔴 4 fail)
Bundle size diffs
|
chrisleewilcox
approved these changes
Aug 11, 2026
hjetpoluru
enabled auto-merge
August 11, 2026 19:09
sleepytanya
approved these changes
Aug 11, 2026
hjetpoluru
added this pull request to the merge queue
Aug 11, 2026
Any commits made after this event will not be merged.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 11, 2026
hjetpoluru
added this pull request to the merge queue
Aug 12, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds class-level JSDoc across e2e page objects with Screen, Owns, Boundaries are documented.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
https://consensyssoftware.atlassian.net/browse/MMQA-2245
Manual testing steps
There is no code changes.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Comment-only updates to test infrastructure; no application or E2E runtime behavior changes.
Overview
Adds class-level JSDoc across the E2E page object tree so each helper documents how tests should use it, without changing selectors or behavior.
Each block follows a shared shape: Screen (route or overlay), Owns (what the class drives in tests), Boundaries (what belongs in other page objects), Related (common hand-offs), and
@seelinks to matching UI or fixture sources. Coverage spans confirmations, home/settings/perps flows, dialogs, hardware wallet, multichain account UI, test dapps/snaps, and bridge/swap wrappers.A few existing one-line comments were expanded to that template (e.g. bottom nav, gas fee modal, perps pages). Shield claim/list files only drop redundant top-of-file comments in favor of the new JSDoc.
Reviewed by Cursor Bugbot for commit eb2b125. Bugbot is set up for automated code reviews on this repo. Configure here.