Skip to content

Conversation

@jvbriones
Copy link
Contributor

@jvbriones jvbriones commented Nov 24, 2025

Migrates some GH workflows to reusable actions.

follow-up PR of these:

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Migrates three GitHub workflows from reusable workflows to MetaMask reusable actions, adds manual triggers where applicable, and updates inputs to kebab-case with explicit runners.

  • CI workflows migrated to reusable actions:
    • check-pr-max-lines: Replace reusable workflow with MetaMask/github-tools/.github/actions/pr-line-check@v1; add runs-on: ubuntu-latest; update inputs to kebab-case (max-lines, ignore-patterns).
    • flaky-test-report: Add workflow_dispatch; replace reusable workflow with .../actions/flaky-test-report@v1; add runs-on; pass inputs via with (including workflow-id, github-token, slack-webhook-flaky-tests).
    • post-merge-validation: Add workflow_dispatch; replace reusable workflow with .../actions/post-merge-validation@v1; add runs-on; update inputs (start-hour-utc, github-token, google-application-creds-base64).

Written by Cursor Bugbot for commit 148bb80. This will update automatically on new commits. Configure here.

@jvbriones jvbriones added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 24, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jvbriones jvbriones requested a review from Mrtenz November 24, 2025 11:24
@metamaskbot metamaskbot added the team-qa QA team label Nov 24, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [148bb80]
UI Startup Metrics (1208 ± 108 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12081004157310812591400
load102585813309610851187
domContentLoaded101985413079410811184
domInteractive26141112520104
firstPaint4908513483829591138
backgroundConnect21319824910220232
firstReactRender2818128123244
getState321889113652
initialActions107113
loadScripts812650109292852968
setupStore1172941122
numNetworkReqs1257820573
BrowserifyPower User HomeuiStartup19641655259721020652464
load1037916187118610111557
domContentLoaded102490418621859951545
domInteractive44182755332197
firstPaint63512518694479941495
backgroundConnect22620726111232243
firstReactRender89541592097132
getState17713030333196245
initialActions103113
loadScripts81370216471847841328
setupStore21105392537
numNetworkReqs1456931755177298
WebpackStandard HomeuiStartup816703108675847996
load63556185468652797
domContentLoaded63155784868649790
domInteractive2715128252298
firstPaint20893658120215599
backgroundConnect1053761016
firstReactRender27194763137
getState271357113648
initialActions103111
loadScripts62855583966647781
setupStore1163251221
numNetworkReqs1257720574
WebpackPower User HomeuiStartup14521110218619115551815
load67458312911306651020
domContentLoaded66557712841306531012
domInteractive43183195332175
firstPaint28687945190357633
backgroundConnect1474261728
firstReactRender84511051393103
getState15012422717158191
initialActions102012
loadScripts66257412731286501002
setupStore21560142551
numNetworkReqs1476534659192296
FirefoxBrowserifyStandard HomeuiStartup12161063170512412691458
load102491013869210751189
domContentLoaded102390513859210751189
domInteractive57292393875134
firstPaint------
backgroundConnect3721223303690
firstReactRender21174852134
getState95395819
initialActions102012
loadScripts100189512678010551155
setupStore105366923
numNetworkReqs1256816664
BrowserifyPower User HomeuiStartup25412055346528127103115
load1156982172317111611516
domContentLoaded1155977172317111601516
domInteractive12835750128115453
firstPaint------
backgroundConnect13631668138127566
firstReactRender86521672096135
getState30168917226443819
initialActions2120227
loadScripts1118958169316411281490
setupStore1397795191114669
numNetworkReqs92622154577201
WebpackStandard HomeuiStartup14481244195714114901793
load1221106214539612971425
domContentLoaded1221106114539612971425
domInteractive55271743378127
firstPaint------
backgroundConnect40181792641106
firstReactRender27197683137
getState156161231248
initialActions102112
loadScripts1197104714098812721372
setupStore146130181261
numNetworkReqs1156716662
WebpackPower User HomeuiStartup26762202348931528933267
load13551087193221213651810
domContentLoaded13541086193221213651810
domInteractive12329624140103512
firstPaint------
backgroundConnect11726568114121445
firstReactRender83431531889119
getState28285860236410798
initialActions4157828
loadScripts13171071188320613171789
setupStore1206748176100648
numNetworkReqs92632114278196
📊 Page Load Benchmark Results

Current Commit: 148bb80 | Date: 11/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±39ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 735ms (±37ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 39ms 1.01s 1.33s 1.10s 1.33s
domContentLoaded 735ms 37ms 701ms 996ms 772ms 996ms
firstPaint 78ms 11ms 64ms 168ms 88ms 168ms
firstContentfulPaint 78ms 11ms 64ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@jvbriones jvbriones added this pull request to the merge queue Nov 24, 2025
Merged via the queue into main with commit c64999b Nov 24, 2025
197 of 199 checks passed
@jvbriones jvbriones deleted the ci-flaky-tests-report branch November 24, 2025 12:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2025
@metamaskbot metamaskbot added the release-13.12.0 Issue or pull request that will be included in release 13.12.0 label Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.12.0 Issue or pull request that will be included in release 13.12.0 size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants