fix: do not add revoke transaction until confirmed by user

[MoMannn]

Description

Fixes bug where if users cancels revocation transaction it gets stuck in pending revocation state.

Changelog

CHANGELOG entry: null

Related issues

Depends on: MetaMask/core#7157

Manual testing steps

1. Create an advance permission
2. Go to All permissions
3. Go to revoke a permission
4. Instead of confirming transaction - cancel it
5. Find the same permissions - you should be able to try to revoke it again

Screenshots/Recordings

Before

Screen.Recording.2025-11-14.at.11.22.22.mov

After

Screen.Recording.2025-11-13.at.14.59.16.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [b64adfb]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1206 ± 85 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1206	1064	1451	85	1260	1383
			load	1046	916	1250	76	1101	1179
			domContentLoaded	1040	911	1226	75	1093	1171
			domInteractive	24	14	97	18	21	73
			firstPaint	644	95	1267	408	1050	1188
			backgroundConnect	235	221	286	9	238	251
			firstReactRender	26	19	40	4	28	36
			getState	22	7	66	10	26	40
			initialActions	1	0	4	1	1	2
			loadScripts	811	694	991	73	864	945
			setupStore	10	6	15	2	11	14
			numNetworkReqs	13	6	72	19	6	70
	Browserify	Power User Home	uiStartup	2102	1905	2351	111	2141	2351
			load	1118	978	1501	179	1327	1501
			domContentLoaded	1100	960	1491	177	1318	1491
			domInteractive	60	18	192	62	117	192
			firstPaint	551	213	1449	374	980	1449
			backgroundConnect	250	232	287	13	253	287
			firstReactRender	67	41	98	15	79	98
			getState	221	176	330	38	247	330
			initialActions	1	0	3	1	2	3
			loadScripts	868	738	1214	167	1083	1214
			setupStore	25	13	38	6	31	38
			numNetworkReqs	123	100	189	27	142	189
	Webpack	Standard Home	uiStartup	863	726	1285	107	869	1148
			load	624	567	1022	88	621	859
			domContentLoaded	616	561	996	83	615	843
			domInteractive	18	12	73	14	15	56
			firstPaint	202	61	998	188	206	586
			backgroundConnect	27	13	80	15	28	60
			firstReactRender	35	20	266	29	36	41
			getState	11	6	21	3	13	16
			initialActions	1	0	2	0	1	1
			loadScripts	613	559	985	81	613	829
			setupStore	11	6	35	4	13	16
			numNetworkReqs	13	6	75	19	8	70
	Webpack	Power User Home	uiStartup	1104	908	1557	224	1403	1557
			load	690	577	1140	172	762	1140
			domContentLoaded	675	566	1121	164	739	1121
			domInteractive	39	13	173	47	77	173
			firstPaint	392	68	1124	350	631	1124
			backgroundConnect	56	17	256	56	70	256
			firstReactRender	40	37	46	2	41	46
			getState	141	96	177	24	153	177
			initialActions	1	0	1	0	1	1
			loadScripts	671	564	1111	161	728	1111
			setupStore	10	7	24	4	9	24
			numNetworkReqs	79	63	121	20	100	121
Firefox	Browserify	Standard Home	uiStartup	1515	1339	2187	130	1555	1772
			load	1262	1129	1553	88	1312	1445
			domContentLoaded	1262	1128	1553	88	1312	1443
			domInteractive	111	35	440	62	115	236
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	27	202	23	48	73
			firstReactRender	27	23	53	5	28	32
			getState	13	7	190	18	12	21
			initialActions	1	1	3	1	2	2
			loadScripts	1237	1112	1516	83	1278	1398
			setupStore	12	7	83	9	11	29
			numNetworkReqs	12	6	66	16	8	60
	Browserify	Power User Home	uiStartup	3634	2884	5069	687	4448	5069
			load	1627	1350	2351	330	1893	2351
			domContentLoaded	1626	1350	2351	330	1893	2351
			domInteractive	246	78	699	213	499	699
			firstPaint	-	-	-	-	-	-
			backgroundConnect	775	183	1479	333	1029	1479
			firstReactRender	92	54	118	17	102	118
			getState	172	109	318	53	204	318
			initialActions	2	2	3	0	2	3
			loadScripts	1570	1304	2316	338	1834	2316
			setupStore	99	48	196	43	120	196
			numNetworkReqs	121	69	232	60	219	232
	Webpack	Standard Home	uiStartup	1602	1391	2285	151	1639	1959
			load	1361	1197	1759	108	1399	1591
			domContentLoaded	1360	1196	1759	108	1399	1590
			domInteractive	54	29	153	27	61	127
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	23	207	28	51	112
			firstReactRender	34	24	126	15	35	71
			getState	12	7	83	9	11	22
			initialActions	1	0	2	1	2	2
			loadScripts	1331	1178	1670	100	1375	1547
			setupStore	17	6	198	23	13	54
			numNetworkReqs	12	6	68	16	7	63
	Webpack	Power User Home	uiStartup	3161	2595	4322	510	3677	4322
			load	1693	1448	2236	223	1818	2236
			domContentLoaded	1692	1448	2235	223	1817	2235
			domInteractive	249	77	704	199	483	704
			firstPaint	-	-	-	-	-	-
			backgroundConnect	366	130	874	247	701	874
			firstReactRender	89	50	128	25	112	128
			getState	168	103	548	101	166	548
			initialActions	2	1	7	1	3	7
			loadScripts	1639	1398	2155	214	1791	2155
			setupStore	137	27	538	147	145	538
			numNetworkReqs	124	67	230	54	190	230

📊 Page Load Benchmark Results

Current Commit: b64adfb | Date: 11/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 992ms (±56ms) 🟢 | historical mean value: 1.04s ⬇️ (historical data)
• domContentLoaded-> current mean value: 689ms (±52ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
• firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	992ms	56ms	952ms	1.32s	1.06s	1.32s
domContentLoaded	689ms	52ms	659ms	978ms	732ms	978ms
firstPaint	76ms	11ms	64ms	164ms	88ms	164ms
firstContentfulPaint	76ms	11ms	64ms	164ms	88ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 945 Bytes (0.02%)
• ui: 11.14 KiB (0.15%)
• common: 2.05 KiB (0.02%)