Skip to content

chore: bump @metamask/profile-sync-controller to ^23.0.0 #34746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2025
Merged

chore: bump @metamask/profile-sync-controller to ^23.0.0 #34746

merged 2 commits into from
Aug 1, 2025
+30 −733

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Jul 30, 2025 •
edited
Loading

Description

This PR bumps @metamask/profile-sync-controller from ^22.0.0 to ^23.0.0.
It also removes a patch that is now unnecessary due to this core PR being merged

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. No manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mathieuartu mathieuartu self-assigned this Jul 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Jul 30, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updated@​metamask/​profile-sync-controller@​22.0.0 ⏵ 23.0.09710086100 +1100

View full report

@metamaskbot
Copy link
Collaborator

Builds ready [60c8839]
UI Startup Metrics (1277 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1277115214496013211394
load109899712665711401206
domContentLoaded109099012615711331196
domInteractive18145271737
firstPaint645132121844711071190
backgroundConnect2111982427213227
firstReactRender20154652131
getState943471026
initialActions40416218
loadScripts886784103857925993
setupStore74263713
WebpackHomeuiStartup24101813292218924762860
load19161382252619219832265
domContentLoaded19061376252119119702245
domInteractive2312230361667
firstPaint1696342680203359
backgroundConnect57123088534282
firstReactRender1678838075199346
getState2442495214198
initialActions62366619
loadScripts18991372249418319672232
setupStore1363851521
FirefoxBrowserifyHomeuiStartup15321362190510415871708
load1332118815858213901488
domContentLoaded1332118715858213901487
domInteractive1093738553110230
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect271788112655
firstReactRender25204532731
getState113172191038
initialActions507210220
loadScripts1308116715588213661465
setupStore10415919633
WebpackHomeuiStartup17411505221514818512018
load14881294179713116111727
domContentLoaded14881293179713116111727
domInteractive1093532747108223
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect291775103351
firstReactRender53426665864
getState113127141333
initialActions5110212317
loadScripts14631269176813015871692
setupStore11412817923
Benchmark value 1277 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1098 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1091 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 211 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 886 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1394 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1207 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1196 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1190 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 227 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 993 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2410 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1917 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1907 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 24 exceeds gate value 21 for chrome webpack home mean domInteractive
Benchmark value 57 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 1900 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2860 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2265 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2245 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 67 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 360 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 283 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 198 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 19 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2232 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1533 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1332 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1332 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1309 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1708 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 230 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 38 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 20 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1742 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1489 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1488 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1464 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2018 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1727 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1727 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 223 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1692 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 2089ms | Sum of p95 exceeds: 2236.8ms
Sum of all benchmark exceeds: 4325.8ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -5 Bytes (0%)
  • ui: -4 Bytes (0%)
  • common: -164 Bytes (0%)

@mathieuartu mathieuartu marked this pull request as ready for review July 31, 2025 12:19
ccharly
ccharly previously approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested though.

fabiobozzo
fabiobozzo previously approved these changes Jul 31, 2025
View reviewed changes
@mathieuartu mathieuartu added this pull request to the merge queue Jul 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2025
@mathieuartu mathieuartu dismissed stale reviews from fabiobozzo and ccharly via 309c6d8 July 31, 2025 16:08
@mathieuartu mathieuartu enabled auto-merge July 31, 2025 16:21
@metamaskbot
Copy link
Collaborator

Builds ready [309c6d8]
UI Startup Metrics (1249 ± 54 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1249114914695412791340
load106996812244810981150
domContentLoaded106295912184810901142
domInteractive18144871739
firstPaint66270117442410681129
backgroundConnect2222092386225232
firstReactRender19153942025
getState12495121626
initialActions30425211
loadScripts84674798947872930
setupStore64132710
WebpackHomeuiStartup24562034287316925682801
load19741543253119920862391
domContentLoaded19621535250519020822337
domInteractive2112200271577
firstPaint1866649283226399
backgroundConnect57113028336281
firstReactRender1528938570189339
getState164220341420
initialActions52183612
loadScripts19581530249418820792327
setupStore166224301421
FirefoxBrowserifyHomeuiStartup14341224212413615001633
load1232108214258512971401
domContentLoaded1231108214248512971401
domInteractive1003626142103199
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2715112152863
firstReactRender25203942733
getState9223125535
initialActions40426216
loadScripts1210106413918212791361
setupStore1039916739
WebpackHomeuiStartup16371413201214117411928
load13821209169911914751606
domContentLoaded13821209169911914751606
domInteractive92303005391244
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect33207393554
firstReactRender52416865762
getState833261123
initialActions5111512515
loadScripts13561187167111714501575
setupStore114159161124
Benchmark value 1250 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1063 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 222 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 847 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2457 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1975 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1963 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 58 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 1958 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2801 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2391 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2338 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 78 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 399 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 281 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2327 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1435 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 199 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 35 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 16 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 39 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1638 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1382 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1382 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 244 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 54 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 1405ms | Sum of p95 exceeds: 2062.8ms
Sum of all benchmark exceeds: 3467.8ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -5 Bytes (0%)
  • ui: -4 Bytes (0%)
  • common: -164 Bytes (0%)

@mathieuartu mathieuartu added this pull request to the merge queue Jul 31, 2025
auto-merge was automatically disabled July 31, 2025 17:19

Pull Request is not mergeable

auto-merge was automatically disabled July 31, 2025 17:19

Pull Request is not mergeable

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2025
@mathieuartu mathieuartu added this pull request to the merge queue Jul 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2025
@mathieuartu mathieuartu added this pull request to the merge queue Jul 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2025
@mathieuartu mathieuartu added this pull request to the merge queue Aug 1, 2025
Merged via the queue into main with commit 7cdc193 Aug 1, 2025
273 of 275 checks passed
@mathieuartu mathieuartu deleted the chore/bump-profile-sync-23.0.0 branch August 1, 2025 11:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2025
@metamaskbot metamaskbot added the release-13.2.0 Issue or pull request that will be included in release 13.2.0 label Aug 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabiobozzo fabiobozzo fabiobozzo approved these changes

@gantunesr gantunesr gantunesr approved these changes

@ccharly ccharly ccharly left review comments

Assignees

@mathieuartu mathieuartu

Labels
release-13.2.0 Issue or pull request that will be included in release 13.2.0 team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mathieuartu @metamaskbot @fabiobozzo @ccharly @gantunesr