-
-
Notifications
You must be signed in to change notification settings - Fork 4
Self hosted runners config #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: e2e-env-actions
Are you sure you want to change the base?
Conversation
2ee461b
to
a1f7d18
Compare
7dd669c
to
2ead7cb
Compare
IMAGE="system-images;android-${{ inputs.android-api-level }};google_apis;${{ inputs.android-abi }}" | ||
echo "Installing additional system image: $IMAGE" | ||
echo "y" | "/opt/android-sdk/cmdline-tools/latest/bin/sdkmanager" "$IMAGE" | ||
shell: bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: AVD Creation Fails Due to Incorrect SDK Component Installation
The setup-e2e-env
action fails to reliably create Android Virtual Devices (AVDs) due to inconsistencies in Android SDK component installation.
- The
Install additional Android SDK components if needed
step's conditional logic (inputs.android-api-level != '34' || inputs.android-abi != 'x86_64'
) usesOR
instead ofAND
, leading to unnecessary installations. More critically, this condition does not account for theinputs.android-tag
. - The system image path within this installation step hardcodes
google_apis
for the tag, instead of using the configurableinputs.android-tag
.
These issues prevent the correct Android system image from being installed, causing the Create Android Virtual Device (AVD)
step to fail when it attempts to use the specified android-tag
.
--device "${{ inputs.android-device }}" \ | ||
--tag "${{ inputs.android-tag }}" \ | ||
--abi "${{ inputs.android-abi }}" \ | ||
--sdcard "${{ inputs.android-sdcard-size }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.