Skip to content

Self hosted runners config #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: e2e-env-actions
Choose a base branch
from

Conversation

makemesteaks
Copy link
Member

No description provided.

@makemesteaks makemesteaks changed the base branch from main to e2e-env-actions July 29, 2025 16:14
@makemesteaks makemesteaks force-pushed the self-hosted-runners-config branch from 2ee461b to a1f7d18 Compare July 29, 2025 16:28
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@makemesteaks makemesteaks force-pushed the self-hosted-runners-config branch from 7dd669c to 2ead7cb Compare July 29, 2025 16:39
cursor[bot]

This comment was marked as outdated.

IMAGE="system-images;android-${{ inputs.android-api-level }};google_apis;${{ inputs.android-abi }}"
echo "Installing additional system image: $IMAGE"
echo "y" | "/opt/android-sdk/cmdline-tools/latest/bin/sdkmanager" "$IMAGE"
shell: bash
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: AVD Creation Fails Due to Incorrect SDK Component Installation

The setup-e2e-env action fails to reliably create Android Virtual Devices (AVDs) due to inconsistencies in Android SDK component installation.

  1. The Install additional Android SDK components if needed step's conditional logic (inputs.android-api-level != '34' || inputs.android-abi != 'x86_64') uses OR instead of AND, leading to unnecessary installations. More critically, this condition does not account for the inputs.android-tag.
  2. The system image path within this installation step hardcodes google_apis for the tag, instead of using the configurable inputs.android-tag.

These issues prevent the correct Android system image from being installed, causing the Create Android Virtual Device (AVD) step to fail when it attempts to use the specified android-tag.

Fix in Cursor Fix in Web

--device "${{ inputs.android-device }}" \
--tag "${{ inputs.android-tag }}" \
--abi "${{ inputs.android-abi }}" \
--sdcard "${{ inputs.android-sdcard-size }}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Redundant Parameters in AVD Creation Command

The avdmanager create avd command redundantly passes --tag and --abi parameters. These values are already included within the --package argument's system image string, which can lead to conflicts or unexpected behavior during AVD creation.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants