-
-
Notifications
You must be signed in to change notification settings - Fork 4
ci: Add release automation #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5595b51 to
ee66471
Compare
5dc82bc to
f390128
Compare
| name: Test add-team-label | ||
| uses: ./.github/workflows/test-add-team-label.yml | ||
| secrets: | ||
| TEAM_LABEL_TOKEN: ${{ secrets.TEAM_LABEL_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Team label test fails on push events
The test-add-team-label workflow is called unconditionally but the underlying action requires github.event.pull_request.user.login and github.event.pull_request.html_url which are only available for pull_request events. Since main.yml triggers on both push and pull_request events, this test will fail when triggered by push events to the main branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in a separate PR: #171
f390128 to
18fccb5
Compare
cryptodev-2s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This adds some workflows from the
metamask-module-templaterepository related to release automation. The only difference is that instead of publishing to NPM, we just publish a tag to GitHub instead.Note
Introduce release automation: create release PRs, detect releases on main, publish GitHub releases with Slack notice and major tag update; add changelog validation.
create-release-pr.ymlto open release PRs viaMetaMask/action-create-release-pr.main.ymlto detect releases onpushbygithub-actions, then invoke reusablepublish-release.yml.publish-release.ymlreusable workflow: posts Slack announcement and publishes GitHub release, then updates shorthand major tag.build-lint-test.ymlto validateCHANGELOG(yarn lint:changelog), with RC-specific validation onrelease/*.scripts/update-major-version-tag.shto managev<major>tags post-release.CHANGELOG.mdscaffold following Keep a Changelog.repositorymetadata andlint:changelogscript inpackage.json.Written by Cursor Bugbot for commit 18fccb5. This will update automatically on new commits. Configure here.