Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 21, 2025

This adds some workflows from the metamask-module-template repository related to release automation. The only difference is that instead of publishing to NPM, we just publish a tag to GitHub instead.


Note

Introduce release automation: create release PRs, detect releases on main, publish GitHub releases with Slack notice and major tag update; add changelog validation.

  • CI/Workflows
    • Add create-release-pr.yml to open release PRs via MetaMask/action-create-release-pr.
    • Update main.yml to detect releases on push by github-actions, then invoke reusable publish-release.yml.
    • Add publish-release.yml reusable workflow: posts Slack announcement and publishes GitHub release, then updates shorthand major tag.
    • Enhance build-lint-test.yml to validate CHANGELOG (yarn lint:changelog), with RC-specific validation on release/*.
  • Scripts
    • Add scripts/update-major-version-tag.sh to manage v<major> tags post-release.
  • Changelog
    • Introduce CHANGELOG.md scaffold following Keep a Changelog.
  • Package
    • Add repository metadata and lint:changelog script in package.json.

Written by Cursor Bugbot for commit 18fccb5. This will update automatically on new commits. Configure here.

@Mrtenz Mrtenz marked this pull request as ready for review November 21, 2025 11:38
@Mrtenz Mrtenz force-pushed the mrtenz/migrate-remaining-workflows branch from 5595b51 to ee66471 Compare November 21, 2025 12:39
@Mrtenz Mrtenz force-pushed the mrtenz/release-automation branch from 5dc82bc to f390128 Compare November 21, 2025 13:12
name: Test add-team-label
uses: ./.github/workflows/test-add-team-label.yml
secrets:
TEAM_LABEL_TOKEN: ${{ secrets.TEAM_LABEL_TOKEN }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Team label test fails on push events

The test-add-team-label workflow is called unconditionally but the underlying action requires github.event.pull_request.user.login and github.event.pull_request.html_url which are only available for pull_request events. Since main.yml triggers on both push and pull_request events, this test will fail when triggered by push events to the main branch.

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a separate PR: #171

@Mrtenz Mrtenz changed the base branch from mrtenz/migrate-remaining-workflows to main November 21, 2025 13:21
@Mrtenz Mrtenz force-pushed the mrtenz/release-automation branch from f390128 to 18fccb5 Compare November 21, 2025 14:20
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz merged commit 0547f04 into main Nov 21, 2025
22 checks passed
@Mrtenz Mrtenz deleted the mrtenz/release-automation branch November 21, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants