Output version#254
Merged
Sam Clarke-Green (t00sa) merged 18 commits intoJun 25, 2026
Merged
Conversation
…ng header info that is needed by the formatters
…(not ideal but the work to allow for the correct solution will be extensive)
Andrew Coughtrie (andrewcoughtrie)
requested review from
Maff Glover (mo-mglover) and
Sam Clarke-Green (t00sa)
and removed request for
Maff Glover (mo-mglover)
June 17, 2026 07:55
Sam Clarke-Green (t00sa)
requested changes
Jun 17, 2026
Sam Clarke-Green (t00sa)
left a comment
Sam Clarke-Green (t00sa)
left a comment
Collaborator
There was a problem hiding this comment.
Nothing major. I've added a couple of comments inline.
Comment on lines
+62
to
+64
| // Broadcast the header length from rank 0 so all ranks know the offset | ||
| int header_length = static_cast<int>(header_buffer.str().length()); | ||
| MPI_Bcast(&header_length, 1, MPI_INT, 0, mpi_context_.get_handle()); |
Collaborator
There was a problem hiding this comment.
This isn't needed because header_length is the same on every task. Might be worth adding a comment to make this clear to future developers.
| */ | ||
|
|
||
| void meto::Formatter::threads(std::ostream &os, hashvec_t hashvec) { | ||
| void meto::Formatter::default_output(std::ostream &header, std::ostream &os, |
Collaborator
There was a problem hiding this comment.
The doxygen comment needs updating. It would also make sense to either change the comments that refer to the key and the header or to change the ostream names to match the comment description.
Andrew Coughtrie (andrewcoughtrie)
requested a review
from Sam Clarke-Green (t00sa)
June 23, 2026 13:09
Sam Clarke-Green (t00sa)
approved these changes
Jun 25, 2026
Sam Clarke-Green (t00sa)
left a comment
Sam Clarke-Green (t00sa)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good!
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've restructured the header output so that it only outputs it once per file (where it used to put the header for each of the ranks in the collated files). The header now includes the output style and the format version which can be picked up by the post-processing apps to check they are working against a format they can deal with. Whilst making these changes I've restructured the
test-output-filessystem tests to both check against known good output (this checks the header only (the first 13 lines) as the time values may change, this should be extended in future but will require more complex output parsing) and names the files uniquely based on the total number of cores being tested on (this avoids a race condition in that the 1 and 2 core tests were naming their output files the same but the files had differing content).Linked issues
Closes # (issue)
Type of change
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: