test parsing and summarisation of outputs (no errors only)#253
Conversation
|
I'm seeing sporadic action runner test failures unrelated to this change, that succeed on re-trigger. I'm assuming there are some synchronisation issues in test running outstanding not related to this change |
|
i have only added the running of the Do you think it's vital that we add correctness checking to these tests, beyond |
Andrew Coughtrie (andrewcoughtrie)
left a comment
There was a problem hiding this comment.
Just one query but otherwise I'd say it's a good enough test for now to make sure the script at least runs.
| python -m pip install .[dev] | ||
| - name: summarise Vernier outputs | ||
| run: | | ||
| find ${{github.workspace}}/build/tests/system_tests -name *vernier-output* -exec echo {} \; -exec summarise-vernier {} \; |
There was a problem hiding this comment.
Running this command locally I needed to put quotes around *vernier-output* otherwise I get the error
find: paths must precede expression: `drhook-vernier-output-1'
find: possible unquoted pattern after predicate `-name'?There was a problem hiding this comment.
always happy to be more explicit with find syntax
Andrew Coughtrie (andrewcoughtrie)
left a comment
There was a problem hiding this comment.
All good now
dbb4575
into
MetOffice:main
Description
Some updates to the Github actions workflows, avoiding warnings for old actions/checkout versions and adding testing of output parsing and summarisation to the matrix of tests
Linked issues
Closes # (issue)
Type of change
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: