Skip to content

Remove rogue SHARED from Fortran library setup#251

Merged
Andrew Coughtrie (andrewcoughtrie) merged 2 commits into
MetOffice:mainfrom
t00sa:static-library-fix
Jun 2, 2026
Merged

Remove rogue SHARED from Fortran library setup#251
Andrew Coughtrie (andrewcoughtrie) merged 2 commits into
MetOffice:mainfrom
t00sa:static-library-fix

Conversation

@t00sa

Copy link
Copy Markdown
Collaborator

Description

The Fortran interface library does not respect the BUILD_SHARED_LIBS setting and always create a shared version. This removes a rogue keyword from the library definition to make the behaviour consistent with the C++ library.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • New tests have been added
  • Tests have been modified to accommodate this change

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes, for both debug and optimised builds

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewcoughtrie
Andrew Coughtrie (andrewcoughtrie) merged commit e6a72c0 into MetOffice:main Jun 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants