Remove rogue SHARED from Fortran library setup#251
Merged
Andrew Coughtrie (andrewcoughtrie) merged 2 commits intoJun 2, 2026
Conversation
Sam Clarke-Green (t00sa)
requested a review
from Andrew Coughtrie (andrewcoughtrie)
May 6, 2026 12:29
Andrew Coughtrie (andrewcoughtrie)
approved these changes
Jun 2, 2026
Andrew Coughtrie (andrewcoughtrie)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Andrew Coughtrie (andrewcoughtrie)
merged commit Jun 2, 2026
e6a72c0
into
MetOffice:main
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Fortran interface library does not respect the
BUILD_SHARED_LIBSsetting and always create a shared version. This removes a rogue keyword from the library definition to make the behaviour consistent with the C++ library.Type of change
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: