vcpkg debug test for ci(windows): bust vcpkg cache on overlay/triplet/requirements changes

.github/workflows/build-test-distribute.yml

@@ -4,7 +4,7 @@ name: Build Test Distribute
 on:
   # Triggers the workflow on push or pull request events but only for the master branch
   push:
-    branches: [ master ]
+    branches: [ master, ci/libzip-zlib-ng-vcpkg-debug-test]
   pull_request:
     branches: [ master ]
 

.github/workflows/build-test-windows.yml

@@ -34,7 +34,7 @@ on:
 
 jobs:
   windows-build-test:
-    timeout-minutes: 70
+    timeout-minutes: 180
     runs-on: ${{ matrix.runner }}
     strategy:
       fail-fast: false
@@ -46,6 +46,7 @@ jobs:
     env:
       BUILD_C_SHARP: ${{ matrix.cxx_compiler == 'msvc-2022' && matrix.build_system == 'CMake' }}
       PYTEST_C_SHARP_ARGS: --run-c-sharp-samples --csharp-sample-dir=..\source\x64\${{ matrix.config }}
+      VCPKG_DEFAULT_TRIPLET: ${{ matrix.vcpkg_triplet || 'x64-windows-meshlib' }}
 
     steps:
       - name: Checkout
@@ -88,10 +89,20 @@ jobs:
           vcpkg.exe integrate install
 
       - name: Restore Vcpkg Cache
+        if: ${{ false }}
         uses: actions/cache@v5
         id: vcpkg-cache
         with:
-          key: vcpkg-cache-${{ matrix.vcpkg-version }}
+          # Cache key includes a hash of everything that influences which
+          # ports get built into C:\vcpkg\installed\. The vcpkg-version
+          # alone is insufficient: MeshLib ships overlay ports under
+          # thirdparty/vcpkg/ports (e.g. a zlib→zlib-ng-compat override,
+          # see MeshInspector/MeshLib#5932) and custom triplets; changes
+          # to any of those must bust the cache or the cached tree is
+          # served verbatim and the overrides never take effect.
+          # Also hashes the install list (windows.txt) and install.bat
+          # so that changing either forces a reinstall.
+          key: vcpkg-cache-${{ matrix.vcpkg-version }}-${{ hashFiles('thirdparty/vcpkg/ports/**', 'thirdparty/vcpkg/triplets/**', 'requirements/windows.txt', 'thirdparty/install.bat') }}
           path: |
             C:\vcpkg\*
 
@@ -101,10 +112,12 @@ jobs:
         with:
           role-to-assume: arn:aws:iam::259351611210:role/GitHubMeshLibAwsCredsRole
           aws-region: us-east-1
+          role-duration-seconds: 7200
 
       - name: Update vcpkg packages
+        # timeout-minutes: 3
         run: |
-          .\thirdparty\install.bat --write-s3
+          .\thirdparty\install.bat --write-s3 --use-s3-asset-provider
 
       - name: Vcpkg integrate install
         working-directory: C:\vcpkg
@@ -188,9 +201,16 @@ jobs:
         env:
           GETTEXT_ROOT: C:\msys64_meshlib_mrbind\clang64
           VCPKG_ROOT: C:\vcpkg
-        # `|| exit /b 1` is used instead of `if errorlevel 1 exit 1`
-        # because the latter can miss exit codes inside parenthesized IF
-        # blocks in cmd.exe (e.g. it failed to catch a ninja build failure).
+        # Error handling: use `|| exit /b 1` chained to each command instead
+        # of the `if errorlevel 1 exit 1` pattern. The latter was failing to
+        # propagate `cmake --build` / ninja failures out of the step on
+        # windows-2025 runners; in a run where ninja reported
+        # `ninja: build stopped: subcommand failed` the step still exited 0
+        # and went on to `xcopy`, which hid the real failure and caused the
+        # next step's linker error for a nonexistent .lib. `|| exit /b 1`
+        # is evaluated at process-exit time rather than via the
+        # errorlevel-in-parens parsing quirks of cmd.exe IF blocks, and is
+        # the documented idiom for robust error propagation in batch files.
         run: |
           if ${{ fromJSON('["1==0", "1==1"]')[matrix.build_system == 'CMake'] }} (
             call "${{matrix.vc-path}}\Common7\Tools\VsDevCmd.bat" -arch=amd64 ${{ fromJSON('["", "-vcvars_ver=14.2"]')[matrix.cxx_compiler == 'msvc-2019'] }} || exit /b 1
@@ -204,7 +224,7 @@ jobs:
           )
 
       - name: Generate and build Python bindings
-        if: ${{inputs.mrbind}}
+        if: ${{inputs.mrbind && matrix.vcpkg_triplet != 'x64-windows-meshlib-iterator-debug'}}
         shell: cmd
         # Note that `\` doesn't work here as a line continuation, and will lead to weird errors.
         run: |
@@ -238,12 +258,13 @@ jobs:
           $xslt.Transform("_report_nunit.xml", "unit_tests_report_nunit.xml")
 
       - name: Python Sanity Tests
+        if: ${{matrix.vcpkg_triplet != 'x64-windows-meshlib-iterator-debug'}}
         timeout-minutes: 8
         working-directory: source\x64\${{ matrix.config }}
         run: py -3 ..\..\..\scripts\run_python_test_script.py -d '..\test_python' -a ' --junit-xml=../unit_tests_report_pytest.xml'
 
       - name: Python Regression Tests
-        if: ${{ inputs.internal_build }}
+        if: ${{inputs.internal_build && matrix.vcpkg_triplet != 'x64-windows-meshlib-iterator-debug'}}
         uses: ./.github/actions/python-regression-tests
         with:
           build_config: ${{ matrix.config }}
@@ -283,12 +304,13 @@ jobs:
         if: ${{ matrix.config == 'Release' }}  # debug builds not supported due to missing file 'tbb12_debug.lib'
         env:
           VCPKG_ROOT: C:\vcpkg
+          VCPKG_TARGET_TRIPLET: ${{ matrix.vcpkg_triplet || 'x64-windows-meshlib' }}
         run: |
           & $env:CMAKE_EXE `
             -S examples/cpp-examples `
             -B cpp-examples-build `
-            -D MESHLIB_INCLUDE_DIRS="$pwd/source;$pwd/thirdparty/parallel-hashmap;$env:VCPKG_ROOT/installed/x64-windows-meshlib/include;$env:VCPKG_ROOT/installed/x64-windows-meshlib/include/eigen3" `
-            -D MESHLIB_LIB_DIRS="$pwd/source/x64/${{ matrix.config }};$env:VCPKG_ROOT/installed/x64-windows-meshlib/lib"
+            -D MESHLIB_INCLUDE_DIRS="$pwd/source;$pwd/thirdparty/parallel-hashmap;$env:VCPKG_ROOT/installed/$env:VCPKG_TARGET_TRIPLET/include;$env:VCPKG_ROOT/installed/$env:VCPKG_TARGET_TRIPLET/include/eigen3" `
+            -D MESHLIB_LIB_DIRS="$pwd/source/x64/${{ matrix.config }};$env:VCPKG_ROOT/installed/$env:VCPKG_TARGET_TRIPLET/lib"
           & $env:CMAKE_EXE `
             --build cpp-examples-build `
             --config ${{ matrix.config }} `
@@ -310,7 +332,7 @@ jobs:
         # https://github.com/actions/download-artifact#maintaining-file-permissions-and-case-sensitive-files
       - name: Archive files
         if: ${{ inputs.upload_artifacts && matrix.cxx_compiler == 'msvc-2019' && matrix.build_system == 'CMake' }}
-        run: tar -a -c -f MREDist_${{ matrix.config }}.zip ./source/x64/${{matrix.config}}
+        run: tar -a -c -f MREDist_${{ matrix.upload_name || matrix.config }}.zip ./source/x64/${{ matrix.config }}
 
       - name: Archive generated C headers
         if: ${{ inputs.upload_artifacts && matrix.cxx_compiler == 'msvc-2019' && matrix.build_system == 'CMake' && matrix.config == 'Release' && inputs.mrbind_c }}
@@ -320,8 +342,8 @@ jobs:
         if: ${{ inputs.upload_artifacts && matrix.cxx_compiler == 'msvc-2019' && matrix.build_system == 'CMake' }}
         uses: actions/upload-artifact@v7
         with:
-          name: WindowsArchive_${{matrix.config}}
-          path: MREDist_${{matrix.config}}.zip
+          name: WindowsArchive_${{ matrix.upload_name || matrix.config }}
+          path: MREDist_${{ matrix.upload_name || matrix.config }}.zip
           retention-days: 1
 
       - name: Collect artifact stats
@@ -330,7 +352,7 @@ jobs:
         uses: ./.github/actions/collect-artifact-stats
         with:
           artifact_path: ${{ github.workspace }}
-          artifact_glob: MREDist_${{matrix.config}}.zip
+          artifact_glob: MREDist_${{ matrix.upload_name || matrix.config }}.zip
           stats_file_suffix: -${{ steps.collect-runner-stats.outputs.job_id }}
 
       - name: Upload MeshLibC2 headers archive

.github/workflows/matrix/windows-finalize-release-config.json

@@ -5,6 +5,7 @@
       "config": "Debug",
       "build_system": "CMake",
       "vcpkg-version": "__VCPKG_VERSION_VS19__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "11.4.2.47141",
@@ -17,12 +18,27 @@
       "config": "Release",
       "build_system": "CMake",
       "vcpkg-version": "__VCPKG_VERSION_VS19__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "11.4.2.47141",
       "CUDA-MAJOR": "11",
       "CUDA-MINOR": "4",
       "test_artifacts_path": "windows/windows-2019/Release"
+    },
+    {
+      "cxx_compiler": "msvc-2019",
+      "config": "Debug",
+      "build_system": "CMake",
+      "vcpkg-version": "__VCPKG_VERSION_VS19__",
+      "vcpkg_triplet": "x64-windows-meshlib-iterator-debug",
+      "upload_name": "Debug-IteratorDebug",
+      "runner": ["windows-2025"],
+      "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
+      "CUDA-VERSION": "11.4.2.47141",
+      "CUDA-MAJOR": "11",
+      "CUDA-MINOR": "4",
+      "test_artifacts_path": "windows/windows-2019/Debug-IteratorDebug"
     }
   ]
 }

.github/workflows/matrix/windows-full-config.json

@@ -5,6 +5,7 @@
       "config": "Debug",
       "build_system": "MSBuild",
       "vcpkg-version": "__VCPKG_VERSION_VS22__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "12.0.1.52833",
@@ -17,6 +18,7 @@
       "config": "Release",
       "build_system": "MSBuild",
       "vcpkg-version": "__VCPKG_VERSION_VS22__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "12.0.1.52833",
@@ -29,6 +31,7 @@
       "config": "Debug",
       "build_system": "CMake",
       "vcpkg-version": "__VCPKG_VERSION_VS22__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "12.0.1.52833",
@@ -41,6 +44,7 @@
       "config": "Release",
       "build_system": "CMake",
       "vcpkg-version": "__VCPKG_VERSION_VS22__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "12.0.1.52833",
@@ -53,6 +57,7 @@
       "config": "Debug",
       "build_system": "MSBuild",
       "vcpkg-version": "__VCPKG_VERSION_VS19__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "11.4.2.47141",
@@ -65,6 +70,7 @@
       "config": "Release",
       "build_system": "MSBuild",
       "vcpkg-version": "__VCPKG_VERSION_VS19__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "11.4.2.47141",
@@ -77,6 +83,7 @@
       "config": "Debug",
       "build_system": "CMake",
       "vcpkg-version": "__VCPKG_VERSION_VS19__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "11.4.2.47141",
@@ -89,12 +96,27 @@
       "config": "Release",
       "build_system": "CMake",
       "vcpkg-version": "__VCPKG_VERSION_VS19__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "11.4.2.47141",
       "CUDA-MAJOR": "11",
       "CUDA-MINOR": "4",
       "test_artifacts_path": "windows/windows-2019/Release"
+    },
+    {
+      "cxx_compiler": "msvc-2019",
+      "config": "Debug",
+      "build_system": "CMake",
+      "vcpkg-version": "__VCPKG_VERSION_VS19__",
+      "vcpkg_triplet": "x64-windows-meshlib-iterator-debug",
+      "upload_name": "Debug-IteratorDebug",
+      "runner": ["windows-2025"],
+      "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
+      "CUDA-VERSION": "11.4.2.47141",
+      "CUDA-MAJOR": "11",
+      "CUDA-MINOR": "4",
+      "test_artifacts_path": "windows/windows-2019/Debug-IteratorDebug"
     }
   ]
 }

.github/workflows/matrix/windows-minimal-config.json

@@ -5,6 +5,7 @@
       "config": "Release",
       "build_system": "CMake",
       "vcpkg-version": "__VCPKG_VERSION_VS19__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "11.4.2.47141",
@@ -17,6 +18,7 @@
       "config": "Debug",
       "build_system": "MSBuild",
       "vcpkg-version": "__VCPKG_VERSION_VS22__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "12.0.1.52833",
@@ -29,12 +31,27 @@
       "config": "Release",
       "build_system": "CMake",
       "vcpkg-version": "__VCPKG_VERSION_VS22__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "12.0.1.52833",
       "CUDA-MAJOR": "12",
       "CUDA-MINOR": "0",
       "test_artifacts_path": "windows/windows-2022/Debug"
+    },
+    {
+      "cxx_compiler": "msvc-2019",
+      "config": "Debug",
+      "build_system": "CMake",
+      "vcpkg-version": "__VCPKG_VERSION_VS19__",
+      "vcpkg_triplet": "x64-windows-meshlib-iterator-debug",
+      "upload_name": "Debug-IteratorDebug",
+      "runner": ["windows-2025"],
+      "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
+      "CUDA-VERSION": "11.4.2.47141",
+      "CUDA-MAJOR": "11",
+      "CUDA-MINOR": "4",
+      "test_artifacts_path": "windows/windows-2019/Debug-IteratorDebug"
     }
   ]
 }

.github/workflows/matrix/windows-standard-config.json

@@ -5,6 +5,7 @@
       "config": "Debug",
       "build_system": "CMake",
       "vcpkg-version": "__VCPKG_VERSION_VS19__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "11.4.2.47141",
@@ -17,6 +18,7 @@
       "config": "Release",
       "build_system": "CMake",
       "vcpkg-version": "__VCPKG_VERSION_VS19__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "11.4.2.47141",
@@ -29,6 +31,7 @@
       "config": "Release",
       "build_system": "MSBuild",
       "vcpkg-version": "__VCPKG_VERSION_VS22__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "12.0.1.52833",
@@ -41,12 +44,27 @@
       "config": "Release",
       "build_system": "CMake",
       "vcpkg-version": "__VCPKG_VERSION_VS22__",
+      "vcpkg_triplet": "x64-windows-meshlib",
       "runner": ["windows-2025"],
       "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
       "CUDA-VERSION": "12.0.1.52833",
       "CUDA-MAJOR": "12",
       "CUDA-MINOR": "0",
       "test_artifacts_path": "windows/windows-2022/Release"
+    },
+    {
+      "cxx_compiler": "msvc-2019",
+      "config": "Debug",
+      "build_system": "CMake",
+      "vcpkg-version": "__VCPKG_VERSION_VS19__",
+      "vcpkg_triplet": "x64-windows-meshlib-iterator-debug",
+      "upload_name": "Debug-IteratorDebug",
+      "runner": ["windows-2025"],
+      "vc-path": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise",
+      "CUDA-VERSION": "11.4.2.47141",
+      "CUDA-MAJOR": "11",
+      "CUDA-MINOR": "4",
+      "test_artifacts_path": "windows/windows-2019/Debug-IteratorDebug"
     }
   ]
 }