fix: Make Echo seamless to run locally on Windows#776
Open
PurdueDM wants to merge 3 commits intoMerit-Systems:masterfrom
Open
fix: Make Echo seamless to run locally on Windows#776PurdueDM wants to merge 3 commits intoMerit-Systems:masterfrom
PurdueDM wants to merge 3 commits intoMerit-Systems:masterfrom
Conversation
Add comprehensive Windows support for local development: - PowerShell equivalent of setup.sh (setup-windows.ps1) - Prerequisite checker script (check-prerequisites-windows.ps1) - Complete Windows setup guide (WINDOWS-SETUP.md) Addresses Merit-Systems#597 by making Echo seamless to run on Windows with: - pnpm installation instructions (npm install -g pnpm) - PowerShell-native scripts (no Git Bash required) - Windows-specific troubleshooting - Docker Desktop setup guidance Fixes: Merit-Systems#597
Enhance main README with: - Explicit prerequisites section (Node, pnpm, Docker, Git) - pnpm installation instructions - Quick start workflow improvements - Reference to WINDOWS-SETUP.md for Windows users - Common issues troubleshooting Addresses Merit-Systems#597
Update packages/app/control/README.md with: - pnpm installation guidance - Windows PowerShell script reference (setup-windows.ps1) - Link to comprehensive WINDOWS-SETUP.md Addresses Merit-Systems#597
Contributor
|
@Bout1 is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #597
This PR makes Echo truly seamless to run locally on Windows by addressing critical setup gaps identified after testing with a fresh Windows environment.
Changes
Windows-Native Support
setup-windows.ps1) - equivalent to bashsetup.shcheck-prerequisites-windows.ps1) - verifies Node, pnpm, Docker, GitWINDOWS-SETUP.md)Documentation Improvements
npm install -g pnpm)Why This Matters
Tested on a fresh Windows environment and discovered users hit these blockers:
pnpm ibut users don't have pnpmsetup.shwon't run in PowerShell without Git BashTesting
Verified on Windows with:
Addresses Gaps in Existing PRs
Existing PRs improved Unix/Mac setup but missed Windows-specific needs:
This PR completes the Windows experience.