Conversation
…election The mode selection between 'new' and 'unhealthy' was using branch_name presence, which derived from BASE with HEAD fallback. Since HEAD is almost always available (via GITHUB_REF_NAME), scheduled/push runs incorrectly selected 'new' mode. Fixes: MRGFY-6820 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Change-Id: I25975a8cfe61b7d51aa28ec9a5ade3701dcc8aac
When `GITHUB_BASE_REF=""` is present (push/scheduled runs), `resource.attributes.get()` returns the empty string instead of falling through to HEAD. Use `or` to ensure the head ref is used when the base ref is falsy, so quarantine keeps working on push/scheduled runs. Relates-To: MRGFY-6820 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Change-Id: If051293b79e15e15c8ee6344eae54cfa00041a8e
Contributor
Author
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 ApprovalThis rule is failing.
🟢 ⛓️ Depends-On RequirementsWonderful, this rule succeeded.Requirement based on the presence of
🟢 Continuous IntegrationWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
sileht
approved these changes
Apr 3, 2026
Base automatically changed from
devs/remyduthu/remyduthu/mrgfy-6820-mode-selection-uses-base-branch-too-broadly/I25975a8cfe61b7d51aa28ec9a5ade3701dcc8aac
to
main
April 3, 2026 11:23
|
@remyduthu this pull request is now in conflict 😩 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
GITHUB_BASE_REF=""is present (push/scheduled runs),resource.attributes.get()returns the empty string instead of fallingthrough to HEAD. Use
orto ensure the head ref is used when the baseref is falsy, so quarantine keeps working on push/scheduled runs.
Relates-To: MRGFY-6820
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Depends-On: #392