feat(ci): redesign quarantine report for readability and error visibility#1030
Merged
mergify[bot] merged 1 commit intomainfrom Mar 16, 2026
Conversation
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 37e10e6. 🟢 All jobs passed!But CI Insights is watching 👀 |
b30386d to
3226522
Compare
3226522 to
72c4a90
Compare
72c4a90 to
b0f3ed2
Compare
…lity The CLI quarantine report was hard to scan in web-based CI consoles (GitHub Actions). Test failures only showed names without error details, forcing developers to scroll through test runner output to find stacktraces. The report lacked visual hierarchy and mixed concerns. Report improvements: - Add intro section explaining what CI Insights does and linking to docs - Display error stacktraces for unquarantined failures using box-drawing characters (┌ │ └─) for clear visual separation - Use ══ heavy separators to frame the header and verdict sections - Show "(no error details in JUnit report)" when failure has no exception attributes, so users understand the absence is expected - Condense verdict into a framed block with consistent X/Y format (e.g. "1/2 failures quarantined", "all tests passed, no quarantine needed") - Skip quarantine section entirely when no failures are detected Error handling improvements: - Display quarantine API errors inline in the report (not hidden in stderr) with⚠️ section, explanation, and detail box - Show all test failure stacktraces when quarantine check fails, treating all failures as unquarantined so users can still see what went wrong - Display upload errors inline with clear messaging about impact ("Mergify CI Insights won't process these test results. Quarantine status and CI outcome are unaffected.") - Remove redundant/confusing error messages (QUARANTINE_INFO_ERROR_MSG) Architecture improvements: - Separate concerns: move all display logic from quarantine.py to cli.py - quarantine.check_and_update_failing_spans now returns a QuarantineResult dataclass instead of an int, carrying categorized span lists - upload.upload() no longer prints — just uploads and raises on error - junit.files_to_spans() returns (run_id, spans) tuple so cli.py controls the run ID display - Extract _run_process test helper to eliminate ~20 lines of boilerplate per test case - Move XML fixtures to tests/ci/fixtures/ directory Test coverage: - 15 test scenarios covering all report paths with full output assertions - Add tests for: invalid XML, empty testsuites, no exception attributes, exception type only, None attributes, upload+quarantine combined errors, multiple report files, pluralization - Consolidate duplicated tests from test_cli.py into junit_processing/test_cli.py - Use realistic error messages (HTTP 422, httpx.ConnectError) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Change-Id: Ib03c1d49ec4e740b021e4bd4a05758ee3b428d06
b0f3ed2 to
37e10e6
Compare
jd
approved these changes
Mar 16, 2026
remyduthu
approved these changes
Mar 16, 2026
Contributor
Merge Queue Status
This pull request spent 2 minutes 31 seconds in the queue, including 2 minutes 17 seconds running CI. Required conditions to merge
|
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI quarantine report was hard to scan in web-based CI consoles
(GitHub Actions). Test failures only showed names without error details,
forcing developers to scroll through test runner output to find
stacktraces. The report lacked visual hierarchy and mixed concerns.
Report improvements:
characters (┌ │ └─) for clear visual separation
attributes, so users understand the absence is expected
(e.g. "1/2 failures quarantined", "all tests passed, no quarantine needed")
Error handling improvements:
with
all failures as unquarantined so users can still see what went wrong
("Mergify CI Insights won't process these test results.
Quarantine status and CI outcome are unaffected.")
Architecture improvements:
dataclass instead of an int, carrying categorized span lists
the run ID display
per test case
Test coverage:
exception type only, None attributes, upload+quarantine combined errors,
multiple report files, pluralization
junit_processing/test_cli.py
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com