Merged
Conversation
Breadcrumbs were hidden on API pages because they were gated behind the `showMarkdownActions` flag. API pages set this to `false` since they don't have markdown source files, but this also suppressed the breadcrumb navigation. Decouple breadcrumb rendering from the markdown actions so breadcrumbs display on all non-homepage pages, while the toolbar buttons (Copy for LLM, View Markdown) remain conditional. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Change-Id: I5ee4dbbdc76f3d7a19b93af48419ce3ba079418b Claude-Session-Id: e2b20a92-6d8f-49e1-a0a3-d33ac77e0b79
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
There was a problem hiding this comment.
Pull request overview
This PR fixes breadcrumb navigation being hidden on API reference pages by decoupling breadcrumb rendering from the showMarkdownActions flag in MainLayout, ensuring breadcrumbs appear on all non-home pages while keeping markdown-related toolbar actions conditional.
Changes:
- Render the breadcrumbs heading bar on all non-homepage routes regardless of
showMarkdownActions. - Keep
CopyForLLMButtonandViewMarkdownButtongated behindshowMarkdownActionsso they remain hidden on pages without markdown sources.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JulianMaurin
approved these changes
Apr 3, 2026
kozlek
approved these changes
Apr 3, 2026
Contributor
Merge Queue Status
This pull request spent 2 minutes 27 seconds in the queue, including 2 minutes 13 seconds running CI. Required conditions to merge
|
49 tasks
mergify
bot
deleted the
devs/jd/fix/api-breadcrumbs/I5ee4dbbdc76f3d7a19b93af48419ce3ba079418b
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breadcrumbs were hidden on API pages because they were gated behind
the
showMarkdownActionsflag. API pages set this tofalsesincethey don't have markdown source files, but this also suppressed the
breadcrumb navigation.
Decouple breadcrumb rendering from the markdown actions so breadcrumbs
display on all non-homepage pages, while the toolbar buttons (Copy for
LLM, View Markdown) remain conditional.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com