Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/components/MergifyCIUploadStep.astro
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ const { reportPath } = Astro.props;
uses: mergifyio/gha-mergify-ci@v8
with:
token: \${{ secrets.MERGIFY_TOKEN }}
report_path: ${reportPath}`}
report_path: ${reportPath}
test_step_outcome: \${{ steps.tests.outcome }}`}
lang="yaml"
theme="slack-ochin"
/>
Expand All @@ -27,4 +28,11 @@ const { reportPath } = Astro.props;
<Code code={`report_path: ${reportPath}`} inline lang="yaml" theme="slack-ochin" />: Points to
where your JUnit file is located. Make sure it matches the path you set in your CI job.
</li>
<li>
<Code code={`test_step_outcome: \${{ steps.tests.outcome }}`} inline lang="yaml" theme="slack-ochin" />:
Passes the test runner step's outcome so Mergify can detect silent failures where the runner
crashed but the JUnit report appears clean. Add an <Code code="id" inline lang="yaml" theme="slack-ochin" /> (such
as <Code code="tests" inline lang="yaml" theme="slack-ochin" />) to your test runner step and
update the <Code code="steps.<id>.outcome" inline lang="yaml" theme="slack-ochin" /> reference to match.
</li>
</ul>
3 changes: 2 additions & 1 deletion src/components/MergifyCIUploadStepMatrix.astro
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ const { reportPath } = Astro.props;
with:
job_name: example_matrix (\${{ matrix.version }})
token: \${{ secrets.MERGIFY_TOKEN }}
report_path: ${reportPath}`}
report_path: ${reportPath}
test_step_outcome: \${{ steps.tests.outcome }}`}
lang="yaml"
theme="slack-ochin"
/>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
In order to benefit from CI Insights Quarantine, you need to add `continue-on-error: true`
in your GitHb Actions step that execute your tests and generates the JUnit file.
in your GitHub Actions step that executes your tests and generates the JUnit file.
The step running the `gha-mergify-ci` action will determine the success or failure conclusion,
considering quarantined tests.

You should also pass `test_step_outcome: ${{ steps.tests.outcome }}` to the step that runs
`mergifyio/gha-mergify-ci` (where `tests` is the `id` of your test runner step) to detect
silent failures where the test runner crashed but the JUnit report appears clean. Without
this input, a crash that produces a partial or empty report could be mistakenly treated as a
success.