Skip to content

Fixed compile warnings on clang #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed compile warnings on clang #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
394859f
Fixed compile warnings on clang
ArnauMendeley Jan 2, 2015
e97a816
Fixed notes from PR
ArnauMendeley Jan 5, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/FileUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ int FileUtils::fileMode(const char* path) throw (IOException)
{
throw IOException("Error reading file permissions for " + std::string(path));
}
return fileInfo.st_mode;
return *reinterpret_cast<int*>(&fileInfo.st_mode);
#else
// not implemented for Windows
return 0;
Expand Down
8 changes: 6 additions & 2 deletions src/UpdateDialogGtkFactory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,12 @@ UpdateDialogGtk* (*update_dialog_gtk_new)() = 0;

bool extractFileFromBinary(int fd, const void* buffer, size_t length)
{
size_t count = write(fd,buffer,length);
return count >= length;
ssize_t count = write(fd,buffer,length);
if(count < 0)
{
return false;
}
return static_cast<size_t>(count) >= length;
}

UpdateDialog* UpdateDialogGtkFactory::createDialog()
Expand Down