issue: 3886011 Removing XLIO Extra API #240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XLIO halts support for Socketxtreme, recvfrom_zerocopy and RX-callback APIs. Signed-off-by: Alexander Grissik <[email protected]>
The USING_EXTRA_API was used to determine whether XLIO or VMA API is in use. Since XLIO API is removed, the USING_EXTRA_API can be replaced by simply USING_VMA_EXTRA_API directly. Signed-off-by: Alexander Grissik <[email protected]>
The std::unary_function and std::binary_function are deprecated since C++11 and are not needed anymore for C++11 containers. Signed-off-by: Alexander Grissik <[email protected]>
Collaborator
Author
|
/review |
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for the XLIO Extra API from sockperf and related components. The changes update header guards, function names, documentation, build configuration, and conditional compilation macros to eliminate XLIO support in favor of the VMA API only.
- Removed XLIO-specific functions, error messages, and preprocessor macros.
- Updated build files and documentation to reflect usage of VMA API.
- Adjusted comments and naming to ensure consistency across modules.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vma-redirect.{h,cpp} | Updated header guard, function names, and comments to remove XLIO. |
| src/sockperf.cpp | Modified API calls and error messages to reference only VMA. |
| src/server.{h,cpp} | Removed XLIO callback paths and retained only VMA-based implementations. |
| configure.ac & Makefile.am | Removed XLIO extra API checks and updated build file references. |
Comments suppressed due to low confidence (3)
src/sockperf.cpp:2165
- The update replacing 'vma_xlio_set_func_pointers' with 'vma_set_func_pointers' is consistent with the removal of XLIO support. Ensure that corresponding error messages and documentation are updated throughout to reflect this change.
bool success = vma_set_func_pointers(optarg);
configure.ac:107
- The removal of XLIO extra API configuration is clear. Please verify that the build scripts and overall documentation have been updated accordingly to avoid misleading references.
AC_MSG_RESULT([${have_xlio_api}])
src/defs.h:169
- Replacing the generic USING_EXTRA_API macro with USING_VMA_EXTRA_API should be reviewed across the codebase to ensure that all conditional compilation paths and macro references are consistently updated.
#ifdef USING_VMA_EXTRA_API // For VMA socketxtreme Only
| * all functions return 'true' on success; 'false' - otherwise | ||
| * | ||
| * NOTE: including this header will redirect all relevant API calls to pointers | ||
| * to functions. Hence, you you are allowed to call any of the relevant APIs, |
There was a problem hiding this comment.
The comment contains a duplicated word ('you you') in the phrase 'you you are allowed to call'. Consider correcting it to improve readability.
Suggested change
| * to functions. Hence, you you are allowed to call any of the relevant APIs, | |
| * to functions. Hence, you are allowed to call any of the relevant APIs, |
Collaborator
|
bot:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See FR 3886011.
XLIO halts support of the extra API used by sockperf.