-
Notifications
You must be signed in to change notification settings - Fork 128
Run without itimer support in alpine #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sockperf_v2
Are you sure you want to change the base?
Conversation
|
Can one of the admins verify this patch? |
| #include <stdlib.h> | ||
| #include <signal.h> | ||
| #include <sys/poll.h> | ||
| #include <stdio.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is stdio.h being included to vma-redirect.h when vma-redirect.cpp has not been touched? Not clear to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, this is another change required to build sockperf in alpine OS
| #endif | ||
|
|
||
| #include "ticks_os.h" | ||
| #include "os_abstract.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, I see that you use os_thread_t in file client.cpp. Why not include header os_abstract.h in client.h?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one of the changes required to properly build in alpine OS, the program was not able to find this file
|
Hi @salsal97, could you provide a motivation not to use |
|
@igor-ivanov , I am running this code inside an Intel SGX secure enclave that does not have support for the itimers syscall yet, hence these modifications in the upstream help us |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows system does not have itimerval too.
Please consider changes in os_abstraction.h|cpp to support Alpine as it is done for WIN.
Probably it is possible to use something as
#ifdef ALPINE
|
@igor-ivanov, the changes made to client.cpp support the use of intel sgx enclaves, which might have itimer support as well in the future |
|
bot:retest |
Added changes to -