remove wrong use of 'struct termio' #276
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Linux implementation of TCGETS in rshim_fuse_console_ioctl() uses
sizeof(struct termio), but the type of bd->cons_termios is
'struct termios', not 'struct termio'.
Also, "man TCGETS" confirms the expected type is 'struct termios':
int ioctl(int fd, TCGETS, struct termios *argp);
I noticed this bug only because glibc recently removed[1] the definition
of struct termio. rshim then failed to build on Fedora Rawhide.
[1] "linux/termio: remove <termio.h> and struct termio"
https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=e04afb71771710cdc6025fe95908f5f17de7b72d
Signed-off-by: Michal Schmidt <[email protected]>
lsun100
reviewed
Jun 18, 2025
Collaborator
lsun100
left a comment
lsun100
left a comment
There was a problem hiding this comment.
Somehow this change caused the 'screen' app to crash when connecting to the device. We'll try to investigate it as well what else might be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux implementation of TCGETS in rshim_fuse_console_ioctl() uses sizeof(struct termio), but the type of bd->cons_termios is 'struct termios', not 'struct termio'.
Also, "man TCGETS" confirms the expected type is 'struct termios':
int ioctl(int fd, TCGETS, struct termios *argp);
I noticed this bug only because glibc recently removed[1] the definition of struct termio. rshim then failed to build on Fedora Rawhide.
[1] "linux/termio: remove <termio.h> and struct termio"
https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=e04afb71771710cdc6025fe95908f5f17de7b72d