Skip to content

Conversation

@dahalperin
Copy link
Contributor

  • Removes the duplicate NetworkAttachmentDefinition CRD from the sriov-network-operator sub-chart and adds it to the exclusion list in hack/release.yaml to prevent it from being re-introduced.
  • Additionally, the release workflow is hardened with || true on the git checkout command to prevent errors if the excluded file does not exist in the previous commit.
  • Fixes: Duplicate crd NetworkAttachmentDefinition when SriovNetworkOperator is enabled #1458

@dahalperin dahalperin changed the title fix: prevent duplicate NetworkAttachmentDefinition CRD fix: prevent duplicate NetworkAttachmentDefinition CRD when SRIOV enabled Nov 10, 2025
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 19233554365

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 37 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.3%) to 62.058%

Files with Coverage Reduction New Missed Lines %
controllers/ipoibnetwork_controller.go 2 83.33%
controllers/nicclusterpolicy_controller.go 2 79.18%
api/v1alpha1/zz_generated.deepcopy.go 4 44.01%
pkg/drain/drain_requestor.go 4 76.39%
pkg/state/state_ipoib_network.go 4 75.24%
controllers/hostdevicenetwork_controller.go 21 68.18%
Totals Coverage Status
Change from base Build 19223820220: -0.3%
Covered Lines: 4143
Relevant Lines: 6676

💛 - Coveralls

Copy link
Collaborator

@almaslennikov almaslennikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dahalperin for addressing this.

@almaslennikov almaslennikov merged commit 5661b20 into Mellanox:master Nov 11, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate crd NetworkAttachmentDefinition when SriovNetworkOperator is enabled

5 participants