Skip to content

Conversation

@e0ne
Copy link
Collaborator

@e0ne e0ne commented Nov 3, 2025

…elease.yaml

@coveralls
Copy link
Collaborator

coveralls commented Nov 3, 2025

Pull Request Test Coverage Report for Build 19070837746

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 57 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.2%) to 62.058%

Files with Coverage Reduction New Missed Lines %
controllers/macvlannetwork_controller.go 2 86.25%
pkg/state/state_ipoib_network.go 4 75.24%
controllers/ipoibnetwork_controller.go 7 77.38%
controllers/nicclusterpolicy_controller.go 44 78.07%
Totals Coverage Status
Change from base Build 19034402612: 0.2%
Covered Lines: 4143
Relevant Lines: 6676

💛 - Coveralls

image: sriov-network-operator-config-daemon-stig-fips
repository: nvcr.io/nvstaging/mellanox
sourceRepository: sriov-network-operator
version: network-operator-v25.10.0-beta.4-stig-fips
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -stig-fips version tag will get overwritten by https://github.com/Mellanox/network-operator/blob/master/.github/workflows/release.yaml#L253
I suggest we add a stig-fips flag here in the release.yaml and handle it in the release workflow

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency - in several of our internal CI jobs (e.g. NGC promotion pipeline), we include logic for handling such StigFips or "-stig-fips" variants.

@almaslennikov almaslennikov merged commit cf5fa71 into Mellanox:master Nov 4, 2025
12 of 14 checks passed
heyvister1 added a commit to heyvister1/network-operator that referenced this pull request Nov 4, 2025
Signed-off-by: Ido Heyvi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants