-
Notifications
You must be signed in to change notification settings - Fork 66
feat: Add sriov-network-operator-config-daemon-stig-fips image into release.yaml #1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…elease.yaml Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
Pull Request Test Coverage Report for Build 19070837746Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
| image: sriov-network-operator-config-daemon-stig-fips | ||
| repository: nvcr.io/nvstaging/mellanox | ||
| sourceRepository: sriov-network-operator | ||
| version: network-operator-v25.10.0-beta.4-stig-fips |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The -stig-fips version tag will get overwritten by https://github.com/Mellanox/network-operator/blob/master/.github/workflows/release.yaml#L253
I suggest we add a stig-fips flag here in the release.yaml and handle it in the release workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can check for this flag like we do for helm chart: https://github.com/Mellanox/network-operator/blob/master/.github/workflows/release.yaml#L262
Here we need to also export the tag for stig-fips flavor: https://github.com/Mellanox/network-operator/blob/master/.github/workflows/release.yaml#L36
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency - in several of our internal CI jobs (e.g. NGC promotion pipeline), we include logic for handling such StigFips or "-stig-fips" variants.
Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
Signed-off-by: Ido Heyvi <[email protected]>
…elease.yaml