Skip to content

Conversation

@heyvister1
Copy link
Collaborator

@heyvister1 heyvister1 commented Nov 3, 2025

Users should not see the following env variables, under network-operator pod, in case useRequestor=false

            - name: MAINTENANCE_OPERATOR_ENABLED
              value: "false"
            - name: MAINTENANCE_OPERATOR_REQUESTOR_ID
              value: nvidia.network-operator-driver-upgrade-controller
            - name: MAINTENANCE_OPERATOR_NODE_MAINTENANCE_PREFIX
              value: network-operator
            - name: MAINTENANCE_OPERATOR_REQUESTOR_NAMESPACE
              value: default

…ariables in case 'Values.operator.maintenanceOperator.useRequestor' is false

Signed-off-by: Ido Heyvi <[email protected]>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 19031303641

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.3%) to 61.697%

Files with Coverage Reduction New Missed Lines %
controllers/macvlannetwork_controller.go 2 86.25%
controllers/drain_controller.go 4 74.63%
pkg/state/state_skel.go 4 83.82%
controllers/nicclusterpolicy_controller.go 13 76.28%
Totals Coverage Status
Change from base Build 19009765267: -0.3%
Covered Lines: 4109
Relevant Lines: 6660

💛 - Coveralls

@heyvister1 heyvister1 requested review from e0ne and rollandf November 3, 2025 10:35
@heyvister1 heyvister1 merged commit 8fc41de into Mellanox:master Nov 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants