-
Notifications
You must be signed in to change notification settings - Fork 66
fix: allow precompiled doca tag in webhook #1788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For example: doca3.1-25.07-0.9.7.0-0-5.14.0-427.87.1.el9_4.x86_64-rhcos4.18-amd64 doca3.1.0-25.07-0.9.7.0-0-5.15.0-151-generic-ubuntu22.04-amd64 25.01-0.6.0.0-0-6.8.0-1019-oracle-ubuntu22.04-arm64 Signed-off-by: Fred Rolland <[email protected]>
|
/retest-nic_operator_kind |
|
/retest-nic_operator_helm |
heyvister1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit. Is there a reason why not calling validator validateNicClusterPolicy in NICClusterPolicy controller? I mean there could be cases where customers might not want to use our validating webhook
Sure, we can do that. Note that in this case, we won't have possibility to bypass in case of bug in validations. |
|
/retest-nic_operator_helm |
|
/retest-nic_operator_kind |
|
/retest-all |
|
/retest-image_scan |
1 similar comment
|
/retest-image_scan |
For example:
doca3.1-25.07-0.9.7.0-0-5.14.0-427.87.1.el9_4.x86_64-rhcos4.18-amd64 doca3.1.0-25.07-0.9.7.0-0-5.15.0-151-generic-ubuntu22.04-amd64 25.01-0.6.0.0-0-6.8.0-1019-oracle-ubuntu22.04-arm64