Skip to content

Conversation

@rollandf
Copy link
Member

For example:
doca3.1-25.07-0.9.7.0-0-5.14.0-427.87.1.el9_4.x86_64-rhcos4.18-amd64 doca3.1.0-25.07-0.9.7.0-0-5.15.0-151-generic-ubuntu22.04-amd64 25.01-0.6.0.0-0-6.8.0-1019-oracle-ubuntu22.04-arm64

For example:
doca3.1-25.07-0.9.7.0-0-5.14.0-427.87.1.el9_4.x86_64-rhcos4.18-amd64
doca3.1.0-25.07-0.9.7.0-0-5.15.0-151-generic-ubuntu22.04-amd64
25.01-0.6.0.0-0-6.8.0-1019-oracle-ubuntu22.04-arm64
Signed-off-by: Fred Rolland <[email protected]>
@rollandf
Copy link
Member Author

/retest-nic_operator_kind

@rollandf
Copy link
Member Author

/retest-nic_operator_helm

Copy link
Collaborator

@heyvister1 heyvister1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. Is there a reason why not calling validator validateNicClusterPolicy in NICClusterPolicy controller? I mean there could be cases where customers might not want to use our validating webhook

@rollandf
Copy link
Member Author

nit. Is there a reason why not calling validator validateNicClusterPolicy in NICClusterPolicy controller? I mean there could be cases where customers might not want to use our validating webhook

Sure, we can do that.
Need to decide on the behavior. (log only, log and set as NotReady)

Note that in this case, we won't have possibility to bypass in case of bug in validations.

@rollandf
Copy link
Member Author

/retest-nic_operator_helm

@rollandf
Copy link
Member Author

/retest-nic_operator_kind

@e0ne
Copy link
Collaborator

e0ne commented Oct 28, 2025

/retest-all

@rollandf
Copy link
Member Author

/retest-image_scan

1 similar comment
@rollandf
Copy link
Member Author

/retest-image_scan

@e0ne e0ne merged commit 5ff3eec into Mellanox:master Oct 29, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants