Skip to content

Conversation

@maze88
Copy link
Collaborator

@maze88 maze88 commented Oct 21, 2025

this PR is coupled with Mellanox/doca-driver-build#163 and with the merge request in our internal CI (so should be merged at the ‘same’ time).

Copy link
Member

@rollandf rollandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maze88 maze88 force-pushed the feature/stig-compliance branch from 92060e4 to 14038dd Compare October 21, 2025 11:00
@coveralls
Copy link
Collaborator

coveralls commented Oct 21, 2025

Pull Request Test Coverage Report for Build 18689743271

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 20 (0.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 61.805%

Changes Missing Coverage Covered Lines Changed/Added Lines %
hack/release.go 0 20 0.0%
Files with Coverage Reduction New Missed Lines %
controllers/drain_controller.go 4 74.63%
pkg/state/state_skel.go 4 83.82%
controllers/nicclusterpolicy_controller.go 8 76.68%
Totals Coverage Status
Change from base Build 18689118497: -0.3%
Covered Lines: 4115
Relevant Lines: 6658

💛 - Coveralls

@maze88
Copy link
Collaborator Author

maze88 commented Oct 21, 2025

Need to also update here:

https://github.com/Mellanox/network-operator/blob/master/.github/workflows/release.yaml#L291-L293

This should do, unless we get a different repo/details from Leon.H later.

@maze88 maze88 force-pushed the feature/stig-compliance branch from 14038dd to 41d8205 Compare October 21, 2025 15:50
@maze88 maze88 merged commit a06972d into Mellanox:master Oct 21, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants