Skip to content

Conversation

@souleb
Copy link
Contributor

@souleb souleb commented Oct 21, 2024

This will enable having dependabot automatic updates for docker images.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11439289064

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 60.25%

Files with Coverage Reduction New Missed Lines %
pkg/state/state_ipoib_network.go 4 75.24%
controllers/ipoibnetwork_controller.go 7 77.38%
Totals Coverage Status
Change from base Build 11406344448: -0.2%
Covered Lines: 3321
Relevant Lines: 5512

💛 - Coveralls

Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@e0ne BTW didnt we want to switch to a client-go binary to avoid using kubectl ?

@rollandf
Copy link
Member

/retest-image_scan

@e0ne
Copy link
Collaborator

e0ne commented Oct 30, 2024

We don't need this once #1118 will be merged

@e0ne e0ne closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants