Skip to content

feat: add support for image building with a custom GOPROXY #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

feat: add support for image building with a custom GOPROXY #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
# Build the image
FROM golang:1.24 as builder

ARG GOPROXY
ENV GOPROXY=$GOPROXY

WORKDIR /workspace
# Copy the Go Modules manifests
COPY go.mod go.mod
Expand Down
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ TARGET_ARCH ?= $(shell go env GOARCH)
GO_BUILD_OPTS ?= CGO_ENABLED=0 GOOS=$(TARGET_OS) GOARCH=$(TARGET_ARCH)
# Linker flags for go build command
GO_LDFLAGS = $(VERSION_LDFLAGS)
GOPROXY ?=


PKGS = $(or $(PKG),$(shell cd $(PROJECT_DIR) && go list ./...))
Expand Down Expand Up @@ -91,7 +92,7 @@ build: ## Build binary

.PHONY: docker-build
docker-build: ## Build docker image with ipam binaries
$(DOCKER_CMD) build -t $(IMG) -f $(DOCKERFILE) .
$(DOCKER_CMD) build -t $(IMG) -f $(DOCKERFILE) --build-arg GOPROXY="$(GOPROXY)" .

.PHONY: docker-push
docker-push: ## Push docker image with ipam binaries
Expand Down
Loading