Skip to content

Conversation

@ykulazhenkov
Copy link
Collaborator

@ykulazhenkov ykulazhenkov commented Jan 13, 2025

  • update dependencies
  • update golang version
  • add dependabot config
  • replace taskfile.dev with make

Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see you didnt like task :)

what triggered its the removal ?

# if this fails, run go mod tidy
- name: Check if module files are consistent with code
run: go mod tidy && git diff --exit-code
coverage:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove coverage ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restored

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12762935556

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-13.2%) to 47.391%

Files with Coverage Reduction New Missed Lines %
cmd/network-operator-init-container/app/app.go 3 58.97%
Totals Coverage Status
Change from base Build 6969809556: -13.2%
Covered Lines: 109
Relevant Lines: 230

💛 - Coveralls

@ykulazhenkov
Copy link
Collaborator Author

i see you didnt like task :)

what triggered its the removal ?

No, the tool is good.
But this project uses simple build logic, so the task tool offers no real benefits. Most of our projects use make, and using a different tool here adds unnecessary complexity. You have to figure out why make isn't working, realize the task tool is used, install it, and recall/learn how to use it.

@ykulazhenkov ykulazhenkov merged commit a3e57c2 into Mellanox:main Jan 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants