-
Notifications
You must be signed in to change notification settings - Fork 29
[CI] issue: HPCINFRA-1736 improve DEB build time #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: vNext
Are you sure you want to change the base?
Conversation
Greptile Summary
Confidence Score: 5/5
Sequence DiagramsequenceDiagram
participant CI as "CI System"
participant globals as "globals.sh"
participant rpm as "rpm.sh"
participant build_pkg as "build_pkg.sh"
participant dpkg as "dpkg-buildpackage"
participant rules as "debian/rules"
participant make as "make"
CI->>globals: "source globals.sh"
globals-->>CI: "make_opt=-j8"
CI->>rpm: "execute rpm.sh"
rpm->>build_pkg: "env make_opt=${make_opt} build_pkg.sh"
build_pkg->>dpkg: "env make_opt=${make_opt} dpkg-buildpackage"
dpkg->>rules: "invoke debian/rules with make_opt env var"
rules->>make: "make ${make_opt} (debug build)"
rules->>make: "dh_auto_build -- ${make_opt} (production build)"
make-->>rules: "parallel compilation complete"
rules-->>dpkg: "build complete"
dpkg-->>build_pkg: "packages created"
build_pkg-->>rpm: "success"
rpm-->>CI: "DEB build complete"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
0e12db0 to
1c81658
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
debian/rules, line 9-13 (link)logic: The main
build:target doesn't include a make command, so the parallel compilation flag${make_opt}won't be used here. After configuration, debhelper'sdh_auto_buildwill run make, but it won't see${make_opt}. Consider addingoverride_dh_auto_buildto use the parallel flag:override_dh_auto_build: $(MAKE) ${make_opt}
3 files reviewed, 1 comment
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
1c81658 to
0b37f95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
debian/rules, line 9-13 (link)logic: parallel compilation flag missing from production build. The
${make_opt}is only applied to the debug build on line 19, but the production build (after this configure step) will be executed by debhelper's automaticdh_auto_buildwithout parallel flags. need to overridedh_auto_buildto pass${make_opt}there too
2 files reviewed, 1 comment
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
0b37f95 to
943f2ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
943f2ad to
c73e2e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
c73e2e2 to
f68b29d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
f68b29d to
1a45c2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
b8a5269 to
39db8d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
Add parallel compilation flag (-j) to DEB builds to improve compile time. Signed-off-by: Noam Tsemah <[email protected]>
39db8d5 to
81af52f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
|
|
||
| # Use parallel build for production build | ||
| override_dh_auto_build: | ||
| dh_auto_build -- ${make_opt} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check if this package can be built without having this variable like it will in UBS
Description
What
Add parallel compilation flag (-j) to DEB builds to improve compile time.
Why ?
HPCINFRA-1736
How ?
It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.
Change type
What kind of change does this PR introduce?
Check list