Skip to content

Conversation

@ntsemah
Copy link

@ntsemah ntsemah commented Nov 11, 2025

Description

What

Replace webrepo.mtr.labs.mlnx with a geoDNS webrepo.gtm.nvidia.com to fix repository timeout issues.
Remove yara-devel package installation due to missing dependencies

Why ?

HPCINFRA-4050

How ?

It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.

Change type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Check list

  • Code follows the style de facto guidelines of this project
  • Comments have been inserted in hard to understand places
  • Documentation has been updated (if necessary)
  • Test has been added (if possible)

@greptile-apps
Copy link

greptile-apps bot commented Nov 11, 2025

Greptile Summary

  • Adds WEBREPO_URL argument and sed replacement to switch from old webrepo address to geoDNS address webrepo.gtm.nvidia.com for repository timeout fix
  • Removes yara-devel package from Oracle Linux 9.4 Dockerfile dependencies

Confidence Score: 1/5

  • This PR has critical implementation issues that will prevent the webrepo replacement from working
  • The sed command on line 11 searches for the literal string $WEBREPO_URL but the repo files contain actual URLs like http://webrepo, making the replacement ineffective. Previous comments correctly identified this as a critical bug requiring the pattern from Dockerfile.rhel8.6:40
  • .ci/dockerfiles/Dockerfile.ol9.4 requires immediate attention - the sed pattern must be fixed before merge

Important Files Changed

Filename Overview
.ci/dockerfiles/Dockerfile.ol9.4 Added WEBREPO_URL replacement logic with incorrect sed pattern and removed yara-devel dependency

Sequence Diagram

sequenceDiagram
    participant Docker as "Docker Build"
    participant Dockerfile as "Dockerfile.ol9.4"
    participant YumRepos as "/etc/yum.repos.d/*.repo"
    participant YumCache as "Yum Cache"
    
    Docker->>Dockerfile: "Build Oracle Linux 9.4 image"
    Dockerfile->>Dockerfile: "Set WEBREPO_URL=webrepo.gtm.nvidia.com"
    Dockerfile->>YumRepos: "sed replace $WEBREPO_URL in repo files"
    YumRepos-->>Dockerfile: "URLs updated"
    Dockerfile->>YumCache: "yum clean all"
    Dockerfile->>YumCache: "yum makecache"
    YumCache-->>Dockerfile: "Cache refreshed"
    Dockerfile->>Dockerfile: "Install packages (without yara-devel)"
    Dockerfile-->>Docker: "Image built"
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@ntsemah
Copy link
Author

ntsemah commented Nov 11, 2025

bot:retest

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

dpressle
dpressle previously approved these changes Nov 18, 2025
Replace webrepo.mtr.labs.mlnx with a geoDNS webrepo.gtm.nvidia.com to fix repository timeout issues.
Remove yara-devel package installation due to missing dependencies

Signed-off-by: Noam Tsemah <[email protected]>
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@galnoam galnoam merged commit 1836f55 into Mellanox:vNext Nov 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants