Skip to content

issue: 4669942 Don't increase error counter on TCP EOF #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

issue: 4669942 Don't increase error counter on TCP EOF #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/lwip/tcp_in.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ void L3_level_tcp_input(struct pbuf *p, struct tcp_pcb *pcb)
PCB. */
tcp_pcb_remove(pcb);
} else {
/* If the application has registered a "sent" function to be
/* If the application has registered an "acked" function to be
called when new send buffer space is available, we call it
now. */
if (pcb->acked > 0) {
Expand All @@ -225,7 +225,7 @@ void L3_level_tcp_input(struct pbuf *p, struct tcp_pcb *pcb)
if (err == ERR_ABRT) {
goto aborted;
}
/* If the upper layer can't receive this data, store it */
/* If the upper layer can't receive this data, drop it */
if (err != ERR_OK) {
pcb->rcv_wnd += in_data.recv_data->tot_len;
pbuf_free(in_data.recv_data);
Expand Down
2 changes: 1 addition & 1 deletion src/core/sock/sockinfo_tcp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2234,7 +2234,7 @@ int sockinfo_tcp::handle_rx_error(bool blocking)
errno = EAGAIN;
}

if (m_p_socket_stats) {
if (unlikely(m_p_socket_stats) && ret == -1) {
if (errno == EAGAIN) {
m_p_socket_stats->counters.n_rx_eagain++;
} else {
Expand Down