Skip to content

Conversation

@NirWolfer
Copy link
Contributor

Description

Clang version in CSbuild is old, and needs to be updated

What

Upgrade Clang-tools-extra from 18.1 to 19.1

Why ?

HPCINFRA-3581

How ?

It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.

Change type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Check list

  • Code follows the style de facto guidelines of this project
  • Comments have been inserted in hard to understand places
  • Documentation has been updated (if necessary)
  • Test has been added (if possible)

Upgrade Clang-tools-extra from 18.1 to 19.1

Signed-off-by: NirWolfer <[email protected]>
Copy link
Collaborator

@dpressle dpressle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check release build i want to make sure we can build release image without UBI

yum makecache && \
yum install -y yum-utils clang-tools-extra-19.1.7 sudo curl autoconf automake make libtool \
libnl3-devel libnl3 rdma-core-devel rdma-core bc && \
yum-config-manager --add-repo https://archives.fedoraproject.org/pub/archive/epel/7/x86_64/ && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That this mean we need epel7 for cppcheck and epel8 for csbuild ?

useradd -u "$_UID" -g "$_GID" -s /bin/bash -m -d ${_HOME} "${_LOGIN}" && \
chown -R ${_LOGIN} ${_HOME} && \
mkdir /build && chown -R ${_LOGIN} /build
RUN rm -f /etc/yum.repos.d/sw-rivermax ubi.repo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment here why we are removing this repo - in few weeks we will forget why we did it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants