-
Notifications
You must be signed in to change notification settings - Fork 29
[CI] issue: HPCINFRA-3512 add support for C++14 in cppcheck container #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: vNext
Are you sure you want to change the base?
Conversation
7639df3 to
020365a
Compare
87bf680 to
68e3568
Compare
|
Test run with split cppcheck and csbuild: |
f9dbd41 to
2b76775
Compare
|
bot:retest |
Currently cppcheck only supports C++11. In this change we update cppcheck to v2.17.1, which fully supports C++14 and add C++14 standard support in cppcheck.sh. In addition, we split cppcheck and csbuild containers as they require different packages and interfere when run in the same container. Signed-off-by: Viacheslav Login <[email protected]>
2b76775 to
95b12f2
Compare
|
/review |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
bot:retest |
|
Can one of the admins verify this patch? |
Description
Add C++14 support in cppcheck container
What
Update the cppcheck static analysis tool to version 2.12.1 with C++14 support in the cppcheck container.
Why ?
The current cppcheck version from EPEL7 repository is outdated and lacks proper support for C++14 features
How ?
Build cppcheck 2.12.1 from source in the CI container, update cppcheck.sh to use --std=c++14 flag
Change type
What kind of change does this PR introduce?
Check list