Skip to content

issue: 4050516 Fix TCP segment leak #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: vNext
Choose a base branch
from
Open

issue: 4050516 Fix TCP segment leak #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/core/sock/sockinfo_tcp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,7 +846,9 @@ sockinfo_tcp::~sockinfo_tcp()
destructor_helper_tcp();

if (m_tcp_seg_in_use) {
si_tcp_logwarn("still %d tcp segs in use!", m_tcp_seg_in_use);
si_tcp_logwarn(
"still %d tcp segs in use! state=%d, pcb.unsent=%p, pcb.unacked=%p, pcb.seg_alloc=%p",
m_tcp_seg_in_use, get_tcp_state(&m_pcb), m_pcb.unsent, m_pcb.unacked, m_pcb.seg_alloc);
}
if (m_tcp_seg_list) {
g_tcp_seg_pool->put_objs(m_tcp_seg_list);
Expand Down Expand Up @@ -1956,6 +1958,11 @@ void sockinfo_tcp::handle_incoming_handshake_failure(sockinfo_tcp *child_conn)

child_conn->lock_tcp_con();

/* Abort the connection first to avoid sending RST/FIN during close().
* tcp_abort() -> tcp_abandon() does NOT send RST for SYN_RCVD state (per Linux behavior).
* This prevents segment allocation during close() path. */
child_conn->abort_connection();

if (safe_mce_sys().tcp_ctl_thread != option_tcp_ctl_thread::CTL_THREAD_DELEGATE_TCP_TIMERS) {
// Object destruction is expected to happen in internal thread. Unless XLIO is in late
// terminating stage, in which case we don't expect to handle packets.
Expand Down