Skip to content

Conversation

@NirWolfer
Copy link
Contributor

Description

Valgrind today is being terminated with -9 which prevents it from printing all the summaries at the end which are needed for debuging.

What

Change -9 signal to -SIGINT af the first try of shutting down Valgrind

Why ?

HPCINFRA-3989

How ?

It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.

Change type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Check list

  • Code follows the style de facto guidelines of this project
  • Comments have been inserted in hard to understand places
  • Documentation has been updated (if necessary)
  • Test has been added (if possible)

@NirWolfer NirWolfer marked this pull request as ready for review October 22, 2025 14:19
@greptile-apps
Copy link

greptile-apps bot commented Oct 22, 2025

Skipped: This PR does not target one of your configured branches: (main, vNext)

@NirWolfer NirWolfer closed this Oct 22, 2025
@NirWolfer NirWolfer reopened this Oct 22, 2025
@NirWolfer
Copy link
Contributor Author

bot:retest

@NirWolfer NirWolfer force-pushed the vg_mem_summary_bugfix branch from fcc5bdf to 50d4440 Compare October 23, 2025 06:59
@NirWolfer NirWolfer changed the title [CI] issue: HPCINFRA-3989 Terminate Valgrind gracefully [CI] issue: 4684071Terminate Valgrind gracefully Oct 23, 2025
Valgrind today is being terminated with -9 which prevents it from
printing all the summaries at the end which are needed for debuging.

Change -9 signal to -SIGINT af the first try of shutting down Valgrind

Signed-off-by: NirWolfer <[email protected]>
@NirWolfer NirWolfer force-pushed the vg_mem_summary_bugfix branch from 50d4440 to ec6f093 Compare October 23, 2025 07:47
@NirWolfer
Copy link
Contributor Author

bot:retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant