feat: add support for image building with a custom GOPROXY #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rollandf
approved these changes
Sep 9, 2025
rollandf
approved these changes
Sep 10, 2025
Makefile
Outdated
| # we keep it fixed to avoid it from unexpectedly failing on the project | ||
| # in case of a version bump | ||
| GOLANGCI_LINT_VER = v1.62.2 | ||
| GOPROXY ?= |
Collaborator
There was a problem hiding this comment.
if left unset it will access the sources directly from what i understand.
the default is:
go env GOPROXY
https://proxy.golang.org,direct
i think we should use whatever is set in the env here if user did not specify
Collaborator
Author
There was a problem hiding this comment.
We'll use what user provides or en empty value, which means 'direct'
Signed-off-by: Ivan Kolodyazhny <[email protected]>
adrianchiris
approved these changes
Sep 16, 2025
almaslennikov
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.