Fix plugin config and NIC prefix #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add go.mod. Remove Gopkg.lock and Gopkg.toml. Use debian:bookwork-slim as the base image. stretch's GLIBC is too old for go1.22.2. Use client version 1.24. All previous versions are obsolete. Add options to build that enable debug. Update imports to use current package names.
Specify ethPrefix in BuildNetworkOptions. Store subnet in JSON. IPv4Data has incorrect values in it. Pool contains the subnet. If a gateway is configured, Gateway does contain the gateway CIDR. If no gateway is configured, Gateway contains the IP range with the subnet's CIDR. This is due to a bug that appears to be in docker/go-plugins-helpers. Isolate IPv4Data struct usage to the driver's CreateNetwork function. Allow for an empty gateway.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct config problems
Specify ethPrefix in BuildNetworkOptions.
Store subnet in JSON.
IPv4Data has incorrect values in it. Pool contains the subnet.
If a gateway is configured, Gateway does contain the gateway
CIDR. If no gateway is configured, Gateway contains the
IP range with the subnet's CIDR. This is due to a bug that
appears to be in docker/go-plugins-helpers.
Isolate IPv4Data struct usage to the driver's CreateNetwork
function.
Allow for an empty gateway.