Skip to content

fix: DTK shared directory path mismatch due to NFD label sanitization #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

fix: DTK shared directory path mismatch due to NFD label sanitization #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dtk_nic_driver_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
: ${ENTRYPOINT_DEBUG:=false}
: ${DTK_OCP_NIC_SHARED_DIR:=/mnt/shared-nvidia-nic-driver-toolkit}

DTK_OCP_NIC_SHARED_DIR=$DTK_OCP_NIC_SHARED_DIR/$(uname -r)
# Sanitize kernel version to match Kubernetes NFD label format used by network-operator for volume paths
# NFD replaces all non-alphanumeric characters (except -._) with underscore, then trims leading/trailing -._
DTK_KVER=$(uname -r | sed 's/[^-A-Za-z0-9_.]/_/g' | sed 's/^[-_.]*//;s/[-_.]*$//')
DTK_OCP_NIC_SHARED_DIR=$DTK_OCP_NIC_SHARED_DIR/$DTK_KVER
DTK_OCP_START_COMPILE_FLAG=""
DTK_OCP_DONE_COMPILE_FLAG=""
DTK_OCP_COMPILED_DRIVER_VER=""
Expand Down
5 changes: 4 additions & 1 deletion entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,7 +1360,10 @@ IS_OS_SLES=true; [[ "$(grep -i sles /etc/os-release -c)" == "0" ]] && IS_OS_SLES
RHEL_MAJOR_VERSION=0
OPENSHIFT_VERSION=""

DTK_OCP_NIC_SHARED_DIR=${DTK_OCP_NIC_SHARED_DIR}/${FULL_KVER}
# Sanitize kernel version to match Kubernetes NFD label format used by network-operator for volume paths
# NFD replaces all non-alphanumeric characters (except -._) with underscore, then trims leading/trailing -._
DTK_KVER=$(echo "${FULL_KVER}" | sed 's/[^-A-Za-z0-9_.]/_/g' | sed 's/^[-_.]*//;s/[-_.]*$//')
DTK_OCP_NIC_SHARED_DIR=${DTK_OCP_NIC_SHARED_DIR}/${DTK_KVER}
DTK_OCP_BUILD_SCRIPT="/root/dtk_nic_driver_build.sh"
DTK_OCP_START_COMPILE_FLAG=${DTK_OCP_NIC_SHARED_DIR}/dtk_start_compile
DTK_OCP_DONE_COMPILE_FLAG_PREFIX=${DTK_OCP_NIC_SHARED_DIR}/dtk_done_compile_
Expand Down
Loading