Add initial unit tests for LogTable with tooling support#62
Open
kevinclark wants to merge 4 commits into
Open
Conversation
Setting up basic usage before going deeper. This pins JUnit5 5.10.1 and removes the unused JUnit4.
Use copyBytes again, and make it static.
5d5da9d to
dd29641
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! I was investingating adding support for serializing collections of serializable objects (Structs and ProtobufSerializables) and wanted unit tests to make that work simpler. I don't think my original effort is going to work in the way I'd hoped, but I've got a branch here that adds JUnit5 support to bazel and writes some initial tests for LogTable which you might find useful.