Reduce GC churn on phoenix odometry thread#263
Open
schveiguy wants to merge 1 commit into
Open
Conversation
instead of a builtin array. Per extracted Phoenix 6 source, the latter is converted to the former, which is a completely needless allocation for the call into the library to update signals.
schveiguy
force-pushed
the
use-arraylist-phoenix-odometry
branch
from
4a27b23 to
a66fb2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per decompiled Phoenix source, the function
BaseStatusSignal.waitForAlland.refreshAllboth will callArrays.asListwhich allocates a wrapperArrayListfor passing to the underlying library. Declaring as anArrayListto begin with avoids this extra allocation.It also simplifies the code a bit to rely on the API of ArrayList instead of implementing appending manually.