Open
Conversation
updated interpreter to check for aliases
added aliases member to command class; added aliases to command help
esLint fixes for Command.js
esLint fixes for App.js
adjusted length of 234 to meet ESLint max-len criteria
|
Changes Unknown when pulling c5364ad on ThePaSch:master into ** on MeLlamoPablo:master**. |
Owner
|
Thanks for the PR! The only thing left is adding tests to cover the new feature and maybe try to get coverage back to 100%. If you don't want to do that; it's ok. I'll do it whenever I can, and merge the PR. Otherwise, let me know if you're going to do it so we don't waste any effort. Here you can see the uncovered lines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the ability to define aliases for any command. Command objects now take an additional member "aliases", an array of strings, which can be used in place of the command's full name and will function just the same.
Cleanup and resubmission of #14.