Skip to content

Made cable faces UNDEFINED #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BernardoCBranco wants to merge 2 commits into
base: 1.12
Choose a base branch
from
Open

Made cable faces UNDEFINED #258

BernardoCBranco wants to merge 2 commits into from

Conversation

@BernardoCBranco
Copy link
Contributor

@BernardoCBranco BernardoCBranco commented Apr 28, 2018

See #255 for info.

@josephcsible
Copy link
Collaborator

josephcsible commented Apr 30, 2018

I wonder if it'd be worth trying to use some of the other choices for BlockFaceShape depending on the cable's connections.

@BernardoCBranco
Copy link
Contributor Author

BernardoCBranco commented Apr 30, 2018

I guess we might as well but I'm uncertain about what it should return in case it's connected, maybe CENTER_SMALL?

@BernardoCBranco
Cables now return blockFaceShape based on connections
7c93a30 
When disguised return value from mimicked block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BernardoCBranco @josephcsible