274: aggregated gap bar UX - live count, next-gap cycling, gate summary - #275
Merged
Conversation
Replace the per-gap callout spam (issue #269 UI) with the aggregated gap UX from issue #274: one live-count gap bar per section with next-gap cycling and an on-demand list, a GOV.UK-style summary at the review gate, and client-side recounting so the bar clears the moment a gap is filled. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The design system sets display:flex on .ed-flag, which beats the UA stylesheet default for the [hidden] attribute - so clean sections showed zero-count gap bars. Re-assert display:none for hidden gap bars, the gate summary, and the collapsed gap list. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🤖 AI Code Review (Gemini 2.5 Pro)✅ No issues found Diff size: 27577 bytes | Reviewed by Gemini 2.5 Pro with thinking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #274
What
Replaces the per-gap callout spam from #269 with an aggregated, live gap UX (researched against GOV.UK error summary, Grammarly, and VS Code Problems-panel patterns):
data-gapbar): "N unresolved gaps" count + Next gap › (cycles selection through[GAP: ...]markers, wrapping) + Show list (expands the missing-fact texts on demand). Replaces N stacked callouts each with their own "Find in text" button.gapScriptJS, shared by /editor and the workspace gate): a client-side mirror offinalreview.GapTextsrecounts on every keystroke — the bar, amber textarea tint, rail dot, and gate summary all clear the moment the last gap is filled, no reload. This fixes the stale "Find in text" buttons that never went away.gapSummary/summarizeGaps): one GOV.UK-style block at the top — "N unresolved gaps across M sections" with anchor links to each section. Hidden at zero gaps.openNonGapFlags): persisted per-gap "Unresolved gap" flags no longer render asgapflagbanners — the summary + bars own gap reporting (previously each gap was reported twice at the gate)..ed-flag { display:flex }beats the UA[hidden]default, so hidden bars rendered as "0 unresolved gaps" callouts;.ed-gap[hidden]etc. re-assertdisplay:none(pinned by test).Unchanged:
gap-warntextarea tint,.gap-markread-only highlighting, section-rail warn dots,finalreview.GapTextsas the single source of truth for the marker grammar.Testing (TDD)
[hidden]CSS rule,summarizeGapspluralization,openNonGapFlagsfiltering.go test ./...),golangci-lint0 issues,gofmtclean. (-racerequires cgo, unavailable on the dev box — CI runs it.)Scope
internal/dashboard/only (editor.go, proposals_templates.go, proposals.go, handler.go, tokens.go + tests). NoOpportunityschema,Store, or agent-contract changes.🤖 Generated with Claude Code