followup to Refactor AUTOTEMP #28175
Merged
+19
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
follow-up-M104_report
branch
from
d36b309 to
f18e01b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since #28155 M503 reports M104 settings formatted incorrectly
Eg
It should report
Missed forReplay parameter in M104_report call in Marlin/src/module/settings.cpp caused the incorrect formatting.
I also corrected indenting in Marlin/src/gcode/temp/M104_M109.cpp
As existing indenting made it look like the code was part of the TERN_ when it is not.
Requirements
#define AUTOTEMP
Benefits
M104_report works as expected
Related Issues