Implement issue #28, replace JS based views consturction with Weld and JS #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at implementing #28
Added jquery.min.js and weld.min.js to the views directory without trying to do anything npm based for resolving these dependencies, if this is a problem please correct me.
While working on this fix I couldn't help but notice that there seems to be inconsistencies with the way webservice.js is expected to behave when asked to expose nested functions. The _extendRouter function in lib/createRouter works only on functions that have one level of nested functions as external properties and doesn't work with objects at all. This contradicts with sample_modules/complexModule.js and made lib/view.js break and not generate documentation for the nested functions.
The fix tried to go around it and introduced the "name" property as a mean to solving this issue, even just for generating correct documentation for nested method, even though there aren't any valid journey routes for them. Changing createRouter was out of scope for this fix.
Cheers!