[Fix] Round points instead of flooring#66
Merged
Conversation
4d26990 to
9ff9408
Compare
mschwoer
approved these changes
Jun 11, 2026
| id = i + 1 | ||
| x = ET.SubElement(root, f"X_CalibrationPoint_{id}") | ||
| x.text = f"{np.floor(point[0]).astype(int)}" | ||
| x.text = f"{int(round(point[0], 0))}" |
There was a problem hiding this comment.
do we know why it was floor in the first place :-)
|
|
||
| y = ET.SubElement(shape, f"Y_{id}") | ||
| y.text = f"{np.floor(point[1]).astype(int)}" | ||
| y.text = f"{int(round(point[1], 0))}" |
There was a problem hiding this comment.
note sure if this is a breaking change: API etc all stays the same, only internal precision changes ..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LMD xml files should only contain integer values.
py-LMD maps floats to integers via
np.floor. Especially if all coordinates are relatively small and for smalll numerical imprecisions, this can lead to numbers that are very far off from the original number.Discussed with @sophiamaedler
Example
This PR implements strategy 3
Rounding + integer gives the closest values to the actual coordinates